Repository navigation
fix: open plans beside writers and preserve literal database paths - #1910
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan inspection and worker CLI calls could fail with
SQLITE_BUSYwhile another writer held the database. Filenames containing URI characters could also open a different database than requested.Current plans now check their existing schema and load their committed state through a read-only connection. Creation and migration retain the serialized writer path, and writes retain the established bounded retry budget with actionable exhaustion guidance. All seven remaining plan/ledger SQLite openers encode literal paths, including relative inputs.
End-to-end evidence
All data is fictional and isolated.
codeaf plandbunder contentiondeepseek/deepseek-v4.1-flash.The isolated CLI acceptance passed in 8.672 seconds. The live workflow passed in 20.841 seconds. Focused regressions reproduce both bugs before the fix and pass afterward; migration, concurrent-open, crash, relative-path, no-create and read-only controls pass. Focused race checks pass across the four changed packages.
make pr-readypassed, including all eight session shards; every selected test passed on its first run.Closes #1462.
Closes #1883.