feat(navigation): add accessible responsive menu to the header#185
Merged
mikewheeleer merged 1 commit intoJun 27, 2026
Conversation
Contributor
|
well done — thanks for picking it up 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #71
Add Accessible Responsive Navigation Menu to Header
Summary
This PR introduces a responsive, accessible navigation menu to the application header. On smaller viewports, the existing horizontal navigation is replaced with a collapsible disclosure menu controlled by a dedicated toggle button. On larger screens, the current inline navigation layout remains unchanged.
The implementation prioritizes accessibility, keyboard navigation, focus management, and responsive behavior while preserving existing navigation semantics and styling.
Problem
The current
Headercomponent renders all navigation links in a single horizontal row without responsive behavior. On narrow screens:Solution
Implemented a responsive disclosure-style navigation menu that:
Changes
Header Component
Updated
src/components/Header.tsxto:<button>element for menu controlaria-expandedandaria-controlsMain navigationaria-labelAccessibility Improvements
Implemented:
Route Change Handling
Added automatic menu closure when navigation occurs to prevent stale open states after route transitions.
Testing
Extended:
src/components/__tests__/Header.test.tsxAdded coverage for:
aria-expandedstate updates appropriatelyDocumentation
Updated
README.mdwith:Testing Performed
Executed:
npm run lint npm run typecheck npm test npm run buildCovered Edge Cases
Accessibility Checklist
Acceptance Criteria