Wrap webhooks list#191
Merged
Merged
Conversation
- Implemented a loading spinner using the shared `Spinner` component for the initial fetch. - Added an empty state using the `EmptyState` component when no webhooks are registered. - Wrapped the registered webhooks list in an accessible `<section>` region. - Improved UX by hiding the loading spinner when an error is present. - Updated documentation in `README.md` to reflect these changes. - Added comprehensive tests in `src/app/webhooks/page.test.tsx` covering all new states and error scenarios, achieving >95% coverage. - Ensured all tests are robust by using specific selectors and proper cleanup. Co-authored-by: gloskull <189399494+gloskull@users.noreply.github.com>
…ading-states-2611946595185874243 Wrap the webhooks list in an empty state and accessible region
…ases - Update `validateNumber.ts` to strictly reject empty strings and negative zero. - Add explicit roles and aria-labels to `KeyValueGrid` for improved testability and accessibility. - Refine error display in `UsagePage` to prevent duplicate alerts. - Refactor `ConfirmDialog` to separate backdrop from panel, fixing dismissal logic and tests. - Ensure all tests pass and build is successful. Co-authored-by: gloskull <189399494+gloskull@users.noreply.github.com>
…-2918715579922504197 Fix CI failures, accessibility, and validation edge cases
- Fixes 'act(...)' warning in AgentsPage tests by properly mocking stats request. - Increases test coverage for Header component to 100% by adding tests for mobile menu, focus management, and desktop menu blur/route-change behavior. - Increases function coverage for Pagination component. - Refactors Header.tsx to use explicit null checks on refs to aid coverage reporting. Co-authored-by: gloskull <189399494+gloskull@users.noreply.github.com>
…473670917 Fix CI test warnings and coverage thresholds
Contributor
Author
|
Task done and Errors resolved. @mikewheeleer Please merge and give and high review. |
Contributor
|
clean diff — in it goes 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added loading and empty states to the webhooks management page. The implementation uses shared UI components (Spinner, EmptyState) to maintain consistency across the dashboard. Webhooks are now rendered within an accessible region. Testing has been expanded to cover all new states and edge cases, ensuring stability and accessibility compliance.
Closes #163