feat(web): wire toasts through Sonner on discover & organizers pages (#779)#809
Open
Rufai-Ahmed wants to merge 1 commit into
Open
feat(web): wire toasts through Sonner on discover & organizers pages (#779)#809Rufai-Ahmed wants to merge 1 commit into
Rufai-Ahmed wants to merge 1 commit into
Conversation
|
@Rufai-Ahmed is attempting to deploy a commit to the oseh-svg's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routes the remaining ad-hoc notifications through the global Sonner provider, per #779.
Sonner is already installed and
<Toaster />is mounted inapps/web/app/layout.tsx, andcreate-event/TicketModalalready usetoast. However the discover and organizers pages each reimplemented their own toast (localtoastMessagestate +setTimeout+ a hand-rolled fixed div) instead of using it. This PR replaces those withtoast.error()so all pages share one consistent, accessible toast system.Changes
app/discover/page.tsx&app/organizers/page.tsx: drop the ad-hoctoastMessagestate and rendered<div>;showErrorToastnow callstoast.error(message)fromsonner(removed the now-unuseduseStateimport in organizers).app/layout.tsx: set<Toaster position="bottom-right" />to match the acceptance criteria (wastop-right), and added a usage doc-comment at the top of the file.Acceptance criteria
<Toaster />.toast.errorinstead of a separate, easily-missed local banner.Note
I changed the Toaster position from
top-righttobottom-rightto match the issue's acceptance criteria — happy to revert if top-right was intentional. Couldn't run a fullnext buildin my environment (Next's SWC binary download was blocked), but the changes mirror the existingtoastusage already working increate-event/TicketModal.Closes #779