Repository navigation
fix(android): include AGP 9 built-in Kotlin classes in metadata generation - #10
Merged
Merged
Conversation
…ation AGP 9 compiles Kotlin into intermediates/built_in_kotlinc/<type>/compile<Type>Kotlin/classes instead of tmp/kotlin-classes, so buildMetadata never saw the app's Kotlin classes. They were missing from the metadata and resolved to undefined in JS (e.g. com.akylas.weather.WeatherIconProviderRegistry). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
farfromrefug
marked this pull request as ready for review
October 21, 2026 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildMetadatanow also collects classes fromintermediates/built_in_kotlinc/<buildType>/compile<BuildType>Kotlin/classes, as task input and in the class list given to the metadata generator.tmp/kotlin-classes, so the app's own Kotlin classes were missing from the metadata and resolved toundefinedin JS (e.g.com.akylas.weather.WeatherIconProviderRegistry).tmp/kotlin-classespath is unchanged.Testing
:app:buildMetadata -Preleaseexits 0.mdg-java-out.txtnow listsWeatherIconProviderRegistry,GadgetbridgeServiceandAnimatableIconView, and the generated metadata containslistInstalledProviders.Related: ossappscollective/oss-weather#570
🤖 Generated with Claude Code