fix: fix issue detect by doubao #94
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,14 +26,29 @@ import ( | |
| type Logger interface { | ||
| Info(args ...any) | ||
| Warn(args ...any) | ||
| Error(args ...any) error | ||
| Debug(args ...any) | ||
| Infof(fmt string, args ...any) | ||
| Warnf(fmt string, args ...any) | ||
| Errorf(fmt string, args ...any) error | ||
| Debugf(fmt string, args ...any) | ||
| } | ||
|
Comment on lines
+29
to
35
There was a problem hiding this comment. 🛠️ Refactor suggestion 🧩 Analysis chainBreaking change: Logger.Error/Errorf now return error. Provide a backward‑compat shim. This breaks existing custom loggers passed via Proposed additions (outside the hunks): // LegacyLogger mirrors the old contract (no error returns).
type LegacyLogger interface {
Info(args ...any)
Warn(args ...any)
Error(args ...any)
Debug(args ...any)
Infof(string, ...any)
Warnf(string, ...any)
Errorf(string, ...any)
Debugf(string, ...any)
}
// Wrap a legacy logger so it satisfies the new Logger.
type legacyLoggerAdapter struct{ LegacyLogger }
func (l legacyLoggerAdapter) Error(args ...any) error { l.LegacyLogger.Error(args...); return nil }
func (l legacyLoggerAdapter) Errorf(f string, a ...any) error {
l.LegacyLogger.Errorf(f, a...); return nil
}
// SetLegacyLogger allows existing integrations to continue working.
func SetLegacyLogger(legacy LegacyLogger) { log = legacyLoggerAdapter{LegacyLogger: legacy} }Search for external uses in this repo: 🏁 Script executed: #!/bin/bash
rg -nP '\bSetLogger\(' -C2Length of output: 183 Add LegacyLogger adapter for backward compatibility // LegacyLogger mirrors the old contract (no error returns).
type LegacyLogger interface {
Info(args ...any)
Warn(args ...any)
Error(args ...any)
Debug(args ...any)
Infof(string, ...any)
Warnf(string, ...any)
Errorf(string, ...any)
Debugf(string, ...any)
}
// legacyLoggerAdapter wraps a LegacyLogger to satisfy the new Logger.
type legacyLoggerAdapter struct{ LegacyLogger }
func (l legacyLoggerAdapter) Error(args ...any) error {
l.LegacyLogger.Error(args...)
return nil
}
func (l legacyLoggerAdapter) Errorf(f string, a ...any) error {
l.LegacyLogger.Errorf(f, a...)
return nil
}
// SetLegacyLogger installs a LegacyLogger for compatibility with SetLogger.
func SetLegacyLogger(legacy LegacyLogger) {
log = legacyLoggerAdapter{LegacyLogger: legacy}
}🤖 Prompt for AI Agents |
||
|
|
||
| // zapLoggerAdapter adapts zap.SugaredLogger to the Logger interface | ||
| type zapLoggerAdapter struct { | ||
| *zap.SugaredLogger | ||
| } | ||
|
|
||
| func (l *zapLoggerAdapter) Error(args ...any) error { | ||
| l.SugaredLogger.Error(args...) | ||
| return nil | ||
| } | ||
|
|
||
| func (l *zapLoggerAdapter) Errorf(fmt string, args ...any) error { | ||
| l.SugaredLogger.Errorf(fmt, args...) | ||
| return nil | ||
| } | ||
|
|
||
| type LoggerLevel int8 | ||
|
|
||
| const ( | ||
|
|
@@ -79,7 +94,7 @@ var ( | |
| func init() { | ||
| zapLoggerConfig.EncoderConfig = zapLoggerEncoderConfig | ||
| zapLogger, _ = zapLoggerConfig.Build() | ||
| log = &zapLoggerAdapter{zapLogger.Sugar()} | ||
|
|
||
| // todo: flushes buffer when redirect log to file. | ||
| // var exitSignal = make(chan os.Signal) | ||
|
|
@@ -114,7 +129,7 @@ func SetLoggerLevel(level LoggerLevel) error { | |
| if err != nil { | ||
| return err | ||
| } | ||
| log = &zapLoggerAdapter{zapLogger.Sugar()} | ||
| return nil | ||
| } | ||
|
|
||
|
|
@@ -128,7 +143,7 @@ func SetLoggerCallerDisable() error { | |
| if err != nil { | ||
| return err | ||
| } | ||
| log = &zapLoggerAdapter{zapLogger.Sugar()} | ||
| return nil | ||
| } | ||
|
|
||
|
|
@@ -163,11 +178,11 @@ func Warnf(template string, args ...any) { | |
| } | ||
|
|
||
| // Error | ||
| func Error(args ...any) error { | ||
| return log.Error(args...) | ||
| } | ||
|
|
||
| // Errorf | ||
| func Errorf(template string, args ...any) error { | ||
| return log.Errorf(template, args...) | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New closeWait channel isn’t reinitialized in Reset(); close(nil) panic risk.
handlePackageclosess.closeWait. AfterReset(),closeWaitbecomes nil (zero value) and closing it will panic.Apply this diff to
Reset():func (s *session) Reset() { *s = session{ name: defaultSessionName, once: &sync.Once{}, done: make(chan struct{}), period: period, wait: pendingDuration, - attrs: gxcontext.NewValuesContext(context.Background()), + attrs: gxcontext.NewValuesContext(context.Background()), + closeWait: make(chan struct{}), } }Also applies to: 161-166
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good advice