Skip to content

fix(admin/updates): match the current ctx.NotFound signature #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rg4444 merged 1 commit into from
May 23, 2026
Merged

fix(admin/updates): match the current ctx.NotFound signature #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions routers/web/admin/updates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,20 +260,20 @@ func UpdateJobView(ctx *gitea_context.Context) {

jobID := ctx.PathParam("jobid")
if jobID == "" {
ctx.NotFound("UpdateJobView", errors.New("missing job id"))
ctx.NotFound(errors.New("missing job id"))
return
}

c := newUpdaterClient()
if c == nil {
ctx.NotFound("UpdateJobView", errors.New("updater not configured"))
ctx.NotFound(errors.New("updater not configured"))
return
}

var job UpdaterJob
if err := c.do(ctx, http.MethodGet, "/update/"+jobID, nil, &job); err != nil {
// 404 from updater also lands here; surface as not-found rather than 500.
ctx.NotFound("UpdateJobView", err)
ctx.NotFound(err)
return
}
ctx.Data["Job"] = &job
Expand Down
Loading