Skip to content

Update omp detection for macOS #15040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 3 commits into from
Feb 10, 2026
Merged

Update omp detection for macOS #15040

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7dfad3
Enhance OpenMP detection for macOS
f3sch Feb 7, 2026
0492de8
Add copyright and license details to CMake file
f3sch Feb 7, 2026
554f506
remove system path hints
f3sch Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 40 additions & 11 deletions dependencies/FindOpenMPMacOS.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,57 @@
# Copyright 2019-2026 CERN and copyright holders of ALICE O2.
# See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
# All rights not expressly granted are reserved.
#
# This software is distributed under the terms of the GNU General Public
# License v3 (GPL Version 3), copied verbatim in the file "COPYING".
#
# In applying this license CERN does not waive the privileges and immunities
# granted to it by virtue of its status as an Intergovernmental Organization
# or submit itself to any jurisdiction.

find_library(OpenMP_LIBRARY
NAMES omp
NAMES omp libomp
HINTS
/opt/homebrew/opt/libomp/lib
/opt/homebrew/lib
Copy link
Copy Markdown
Member

@ktf ktf Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not have "/opt/homebrew/lib" or "/usr/local/lib" in the hints. If that happens to be selected, then it becomes impossible to override single packages. I would prefer if the OpenMP support and detection is driven from the outside.

Copy link
Copy Markdown
Collaborator Author

@f3sch f3sch Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. Just to understand /opt/homebrew/opt/libomp/lib is fine though, no right? How do you imagine the support be driven from the outside, in the recipe?

Copy link
Copy Markdown
Member

@ktf ktf Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, /opt/homebrew/opt/libomp/lib is fine. For support driven from the outside I mean via some -DOPENMP_DIR=$(brew --prefix libomp)

/usr/local/opt/libomp/lib
/usr/local/lib
)

find_path(OpenMP_INCLUDE_DIR
omp.h
NAMES omp.h
HINTS
/opt/homebrew/opt/libomp/include
/opt/homebrew/include
/usr/local/opt/libomp/include
/usr/local/include
)

mark_as_advanced(OpenMP_LIBRARY OpenMP_INCLUDE_DIR)

include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(OpenMP DEFAULT_MSG
OpenMP_LIBRARY OpenMP_INCLUDE_DIR)
find_package_handle_standard_args(
OpenMPMacOS
DEFAULT_MSG
OpenMP_LIBRARY OpenMP_INCLUDE_DIR
)

if (OpenMP_FOUND)
if (OpenMPMacOS_FOUND)
set(OpenMP_LIBRARIES ${OpenMP_LIBRARY})
set(OpenMP_INCLUDE_DIRS ${OpenMP_INCLUDE_DIR})
set(OpenMP_COMPILE_OPTIONS -Xpreprocessor -fopenmp)

set(OpenMP_CXX_FOUND True)
set(OpenMPMacOS_FOUND True)
add_library(OpenMP::OpenMP_CXX SHARED IMPORTED)
set(OpenMP_CXX_FOUND TRUE)
set(OpenMP_FOUND TRUE)

add_library(OpenMP::OpenMP_CXX INTERFACE IMPORTED)
set_target_properties(OpenMP::OpenMP_CXX PROPERTIES
IMPORTED_LOCATION ${OpenMP_LIBRARIES}
INTERFACE_INCLUDE_DIRECTORIES "${OpenMP_INCLUDE_DIRS}"
INTERFACE_COMPILE_OPTIONS "${OpenMP_COMPILE_OPTIONS}"
INTERFACE_COMPILE_OPTIONS "-Xclang;-fopenmp"
INTERFACE_LINK_LIBRARIES "${OpenMP_LIBRARIES}"
)
message(STATUS
"Found OpenMP (macOS workaround): "
"library=${OpenMP_LIBRARY}, "
"include=${OpenMP_INCLUDE_DIR}"
)
endif()