Skip to content

[O2B-1575] Remove limited waiting time from test#2123

Open
NarrowsProjects wants to merge 4 commits intomainfrom
fix/O2B-1575/remove-limited-waiting-time-from-test
Open

[O2B-1575] Remove limited waiting time from test#2123
NarrowsProjects wants to merge 4 commits intomainfrom
fix/O2B-1575/remove-limited-waiting-time-from-test

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Mar 27, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • none

Notable changes for developers:

  • the wait time was removed for the export button test in runsperlhc overview test

Changes made to the database:

  • None

@NarrowsProjects NarrowsProjects self-assigned this Mar 27, 2026
@NarrowsProjects NarrowsProjects added the javascript Pull requests that update Javascript code label Mar 27, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.50%. Comparing base (c4052b4) to head (23adc99).

Files with missing lines Patch % Lines
.../Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2123      +/-   ##
==========================================
+ Coverage   45.33%   45.50%   +0.17%     
==========================================
  Files        1044     1044              
  Lines       17354    17353       -1     
  Branches     3150     3149       -1     
==========================================
+ Hits         7867     7897      +30     
+ Misses       9487     9456      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects force-pushed the fix/O2B-1575/remove-limited-waiting-time-from-test branch from fedb3c7 to a055513 Compare March 27, 2026 15:42
// eslint-disable-next-line no-undef
model.runs.perLhcPeriodOverviewModel.pagination.itemsPerPage = 10;
model.runs.perLhcPeriodOverviewModel.pagination.itemsPerPage = 2;
});
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could do with an explanation.

What happened here before was:

  1. The number of Items was set
  2. The next test runs
  3. The page is loaded based on the previous number of items.
  4. The number of items is changed
  5. a. Sometimes, the waitForButtonToBecomeActive resolves immediately because the change in item number doesn't result in a UI change quick enough. This will result in a failure because the button might be inactive after the active check passed.
    b. Sometimes waitForButtonToBecomeActive doesn't immediately resolve because the UI would be loading, which would temporarily disable the button. This would result in a test pass

Moving the setting as well as the row check to a previous test solves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

1 participant