[O2B-1575] Remove limited waiting time from test#2123
Open
NarrowsProjects wants to merge 4 commits intomainfrom
Open
[O2B-1575] Remove limited waiting time from test#2123NarrowsProjects wants to merge 4 commits intomainfrom
NarrowsProjects wants to merge 4 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2123 +/- ##
==========================================
+ Coverage 45.33% 45.50% +0.17%
==========================================
Files 1044 1044
Lines 17354 17353 -1
Branches 3150 3149 -1
==========================================
+ Hits 7867 7897 +30
+ Misses 9487 9456 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fedb3c7 to
a055513
Compare
NarrowsProjects
commented
Mar 29, 2026
| // eslint-disable-next-line no-undef | ||
| model.runs.perLhcPeriodOverviewModel.pagination.itemsPerPage = 10; | ||
| model.runs.perLhcPeriodOverviewModel.pagination.itemsPerPage = 2; | ||
| }); |
Collaborator
Author
There was a problem hiding this comment.
This could do with an explanation.
What happened here before was:
- The number of Items was set
- The next test runs
- The page is loaded based on the previous number of items.
- The number of items is changed
- a. Sometimes, the waitForButtonToBecomeActive resolves immediately because the change in item number doesn't result in a UI change quick enough. This will result in a failure because the button might be inactive after the active check passed.
b. Sometimes waitForButtonToBecomeActive doesn't immediately resolve because the UI would be loading, which would temporarily disable the button. This would result in a test pass
Moving the setting as well as the row check to a previous test solves this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: