OCTRL-1078 Make Task Controller able to control OCC tasks#804
OCTRL-1078 Make Task Controller able to control OCC tasks#804justonedev1 wants to merge 6 commits intomasterfrom
Conversation
knopers8
left a comment
There was a problem hiding this comment.
thanks! I did not try to run it yet, but I already have some questions/suggestions.
control-operator/ecs-manifests/control-workflows/stfbuilder-senderoutput-kube.yaml
Show resolved
Hide resolved
| command: ["/opt/o2/bin/o2-readout-exe"] | ||
| args: ["consul-ini://mtichak-ost.cern.ch:8500/o2/components/readout/ANY/any/readout-stfb-mtichak-ost"] | ||
| # setup proper uri for your test case change this part | ||
| args: ["consul-ini://localhost:8500/o2/components/readout/ANY/any/readout-stfb-mtichak-ost"] |
There was a problem hiding this comment.
aah, we don't need any changes to the file, but it's auto-generated with the file name including the host name, am I correct?
There was a problem hiding this comment.
yes, the argument is autogenerated by ansible during flp-suite deployment... But as far as I know (I haven't tried this) you can just pass config file to readout and it will be fine. .. The file in question http://mtichak-ost.cern.ch:8500/ui/alice-o2-cluster/kv/o2/components/readout/ANY/any/readout-stfb-mtichak-ost/edit doesn't contain any generated snippets as far as I can say. So we might probably be fine to store it in the repo and make the example args containing the path of this config file.
There was a problem hiding this comment.
ah, I can get around consul with following: https://kubernetes.io/docs/concepts/configuration/configmap/
There was a problem hiding this comment.
I added shm arguments to all kubernetes examples and used configMap for kubernetes, which creates config image in /etc/readout/readout-config.ini
introduction of controller for kubernetes inside the controller-operator folder.
This version allows us to control all OCC tasks (tested on readout, stfsender and stfbuilder). Currently there is not image and controller was run directly via
make runon the node where the kubernetes cluster is running. If you run it locally and cluster is on different computer, you would not be able to communicate with OCC process as these require opened portsManifests required to run these tasks are inside the
ecs-manifestssubfolder.In order to apply these manifests use
kubectl. There is an explanation which file is which inside thekubernetes-ecs.md.