fix(stack-monitor): real version signal for litellm/llama.cpp/comfyui + ROLLING status#49
Merged
Merged
Conversation
… + ROLLING status The daily GitHub Monitor cron reported "version format unknown" for every rolling-tag / source-built service and compared ComfyUI against a stale hardcoded pin (v0.20.1 while the box runs 0.17.0). - resolve_current_version(): read ComfyUI live from comfyui_version.py and LiteLLM live from the running model-gateway container (it has no version pin anywhere — model-gateway is FROM litellm:main-stable). - New ROLLING severity for non-semver pins (llama.cpp server-cuda) so they surface for manual review instead of a misleading MEDIUM "version unknown". - Harden run_cmd with UTF-8/errors=replace (crashed on non-UTF-8 release notes on a cp1252 host, leaving stdout=None). - Drop the stale ComfyUI/LiteLLM hardcodes from PINNED. Tests: tests/test_stack_monitor_versions.py (7 new, all pass). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
a88efd4 to
6b76faa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The daily GitHub Monitor repo-news cron (
scripts/stack_monitor.py) gave no usable signal for several services:FROM ghcr.io/berriai/litellm:main-stable, a rolling tag) → fell intoclassify_severity's no-digit branch → silentMEDIUM / "Version format unknown"every run.server-cudarolling tag + TurboQuant fork) → same dead end.v0.20.1while the box actually runs0.17.0.Fix
resolve_current_version()reads ComfyUI live fromdata/comfyui-storage/ComfyUI/comfyui_version.pyand LiteLLM live from the runningmodel-gatewaycontainer.run_cmdhardened to UTF-8/errors=replace(crashed on non-UTF-8 release notes on a cp1252 host, leavingstdout=None).PINNEDhardcodes for ComfyUI/LiteLLM.Validation
Full E2E run now reports real deltas: LiteLLM
1.82.3 → v1.89.2, ComfyUI0.17.0 → v0.25.1, llama.cppserver-cuda → b9724(ROLLING), Hermes CRITICAL (security note).tests/test_stack_monitor_versions.py— 7 new tests, all 14 pass.🤖 Generated with Claude Code