Repository navigation
fix: sanitize shell/subprocess call in util.go (CWE-78) - #9666
Merged
okatu-loli merged 1 commit intoOct 13, 2026
Merged
okatu-loli merged 1 commit into
okatu-loli merged 1 commit into
Conversation
Automated security fix generated by OrbisAI Security
skysliences
approved these changes
Oct 12, 2026
JoaHuang
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FFmpeg video processing functions pass user-controlled file paths to ffmpeg.Input() without adequate sanitization. While a sanitizeFilePath function exists, it only validates that the path is absolute, clean, and a regular file. It does not prevent command injection through FFmpeg's complex input syntax, which supports various protocols (file:, pipe:, http:, concat:, subfile:) and options that can be abused for arbitrary file read or command execution. The affected code is
drivers/local/util.go:110. This change is the fix I would apply.Reference: CWE-78
What changed
drivers/local/util.goVerification
No automated check could be run against this repository, so this change is unverified beyond review. Please treat it as a suggestion.
Automated security fix by OrbisAI Security