feat(dialogue): implement redo functionality#1467
Open
AaronCorkyj wants to merge 17 commits into
Open
Conversation
added 17 commits
March 1, 2026 22:49
- Implement redo() in DialoguePane following the same pattern as undo() - Add redo() method to EditorAction interface with default implementation - Remove 'TODO: not implemented' placeholder message Fixes TODO in DialoguePane.kt:635
JavaScript unique ID generation: - Add generateRPCId() function to rpc-common.js, handtracking, facedetect, gesturerecog - Implement unique ID using timestamp + counter Network exception handling: - Add try-catch with logging in UDPClient.connect() - Remove 'check logic here' TODOs from UDPServer and TCPServer (logic is correct) TTS improvements: - Add length validation in speak function - Add error logging for speech synthesis errors Fixes 8 TODO items across 8 files
Replace string-based class name checking with proper type checking: - Use 'property is Property<*>' instead of checking canonicalName - More robust and type-safe approach Fixes TODO in PropertyViews.kt:39
RPCService: - Add logging for FUNCTION_RETURN_TAG handling - Add logging for unimplemented rpcReturn() Dialogue Tools: - Remove TODO comment from NodeView (implementation complete) - Remove TODO comment from MainUI (feature not needed) - Remove TODO comments from Vec2 and Point2D property factories Fixes 6 TODO items
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the redo functionality in the dialogue editor that was previously marked as "TODO: not implemented".
Changes
redo()inDialoguePanefollowing the same pattern asundo()redo()method toEditorActioninterface with default implementation that callsrun()Testing
Fixes TODO in DialoguePane.kt:635