Skip to content

Fix issue #1581: _re_proj in update_proj replaces **all** name attributes in pyproject.toml#1582

Merged
jph00 merged 2 commits intoAnswerDotAI:mainfrom
MIS-Analytics:main
Apr 10, 2026
Merged

Fix issue #1581: _re_proj in update_proj replaces **all** name attributes in pyproject.toml#1582
jph00 merged 2 commits intoAnswerDotAI:mainfrom
MIS-Analytics:main

Conversation

@JonasJakubassa
Copy link
Copy Markdown

Fix issue #1581. See issue for description.

Work done together with @janhesse53.

See also solveit dialog: https://share.solve.it.com/d/772cd0fefa8435ad2e3d26b4e43d5ce6

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Comment thread nbdev/config.py

[tool.uv]
cache-keys = [{ file = "pyproject.toml" }, { file = "setup.py" }]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this - it's not something that should be default afaict.

@jph00
Copy link
Copy Markdown
Contributor

jph00 commented Apr 10, 2026

Thanks! :)

@jph00 jph00 merged commit bb00ebb into AnswerDotAI:main Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants