Port many features to 26.1 part.2#4188
Conversation
WhereisFff
commented
Jul 17, 2026
- Resolved large cauldrons, adjusted crafting recipes, and fixed bugsssssss 实现了大型炼药锅,修改了一些配方,修复了许多问题 #4161
- Recipe change and more improvement and bug fix 调整配方以及一些其它优化和修bug #4177
- Update large_cauldron.json #4182
- Fix bugs, adjust CFA special planet seed items, revise overseer model and blockstate #4183
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason: Security scan — [HIGH] Pipe to interpreter: curl | python3: Command pipes output from 'curl' directly to interpreter 'python3'. Downloaded content will be executed without inspection. Reply |
Reason: Security scan — [MEDIUM] Variation selector characters detected: Content contains Unicode variation selectors (VS1-256). These are commonly used in emoji sequences but may indicate steganographic encoding or obfuscation Reply |
Reason: Security scan — [HIGH] Pipe to interpreter: curl | python3: Command pipes output from 'curl' directly to interpreter 'python3'. Downloaded content will be executed without inspection. Reply |
|
我已经收集了足够的分析数据。以下是审查结果: 代码审查摘要 — PR #4188操作: opened ✅ API 迁移健康度
🔴 关键问题无。
|
| 声称(引用 PR) | 状态 | 对应文件 |
|---|---|---|
| #4161 Large Cauldron | ✅ | LargeCauldronBlock、LargeCauldronBlockEntity、LargeCauldronFluidHandler、LargeCauldronInputHandler、LargeCauldronBlockEntityRenderer、LargeCauldronRenderState、LargeCauldronTooltipProvider、ModBlocks.LARGE_CAULDRON、ModBlockEntities.LARGE_CAULDRON、ModCapabilities |
| #4177 配方重构 | ✅ | FastCookingRecipe、SolidLiquidRecipe、FluidMixingRecipe、FastCookingRecipeLoader、SolidLiquidRecipeLoader、FluidMixingRecipeLoader、DecayCategory、移除旧的 Boiling/Bulging/Cooking |
| #4182 Overseer 扩展 | ✅ | OverseerBlock(MAX_LEVEL=4、形状)、OverseerBlockEntityRenderer(新)、OverseerRenderState(新)、OverseerTrailParticle(新)、ModParticles、ModSoundEvents、ModBlockEntities.OVERSEER(添加 renderer) |
| #4183 NestingShulkerBox 删除 + BlockDevourer | ✅ | 移除 NestingShulkerBoxBlock 等(×3 层级)、BaseNestingShulkerBoxBlockEntity、UncontainableBlockItem、BlockDevourerBlock(BlockMiningEffect)、FireReforgingUtil、FishTankBlockEntity lava repair |
| AccelerationRing 改善 | ✅ | getRingsAlongMovement()、ringsBySection 索引 |
| WaterloggedFlexibleMultiPart | ✅ | 新类 WaterloggedFlexibleMultiPartBlock |
| BatchCrafterSelectPacket | ✅ | 新网络包 |
| JEI Decay 类别 | ✅ | 新 DecayCategory + DecayRecipe(替代 VoidDecay + Transcendium) |
结论:APPROVE ✅
此 PR 完整、干净地将 4 个先前 PR 的特征移植到 26.1 分支。API 迁移健康度优秀(jspecify ✅、Identifier ✅、无旧 API 残留),所有注册完整性检查通过,删除完整性通过。没有发现关键问题。警告仅涉及文档(EOF 换行)和极小的旧 API 使用(标准模式,不阻塞)。
由 Hermes Agent 审查
|
Now I have a comprehensive understanding of the PR. Let me compile the review. 代码审查摘要 — PR #4188操作: review_requested / synchronize ✅ API 迁移健康度
结论:26.1 API 迁移状态非常健康。 旧 API(jetbrains Nullable、ResourceLocation、IFluidHandler、@onlyin)已完全迁移至新 API(jspecify、Identifier、ResourceHandler)。 🔴 关键暂无阻塞性问题。
|
| 声称 | 状态 | 对应文件 |
|---|---|---|
| #4161 加速环系统 | ✅ | AccelerationRingBlock.java/.entity, DeflectionRingBlock.java/.entity, AccelerateManager.java |
| #4182 挖掘效果/BlockDevourer | ✅ | BlockMiningEffect.java, BlockDevourerBlock.java, BreakBlockUtil.java |
| #4183 流体系统重构 | ✅ | LargeCauldronBlock.java/.entity, LargeCauldronFluidHandler.java, SingleFluidTankHandler.java, MultiFluidTankHandler.java, FluidTankBlockEntity.java, LargeFluidTankBlockEntity.java, FishTankBlock.java/.entity, FluidMixingRecipe.java |
| #4177 Multiphase 简化 | ✅ | Multiphase.java, WheelLifecycleEventListener.java, MultiphasePackets.java, MultiphaseCommand.java |
| 配方系统统一迁移 | ✅ | 10 个旧 recipe wrapper 删除 + 5 个新 wrapper 添加 + JEI 类别重建 |
| CFA/Laser 挖掘效果传播 | ✅ | BaseLaserBlockEntity.java, CelestialForgingAnvilLaserInterfaceBlockEntity.java, CfaInterfaceScanner.java, LensBlock.java/.entity, LensType.java |
| Nesting Shulker Box 完整删除 | ✅ | 8 个 Java 文件 + 3 个 item JSON 删除 |
| 铁砧轨道弹射性能 | ✅ | AccelerationRingBlockEntity.java 空间索引优化 |
| BatchCrafter 多配方 | ✅ | BatchCrafterBlockEntity.java, BatchCrafterMenu.java, BatchCrafterScreen.java |
| Heater 红石控制 | ✅ | HeaterBlock.java, HeaterBlockEntity.java, BasePowerConverterBlock.java |
结论: APPROVE — PR 在 26.1 API 迁移健康度方面表现优异,所有旧 API 已完全迁移。功能实现完整,注册链验证通过,删除完整性良好。主要关注点仅为生成资源的 EOF 缺失(不影响运行时,但建议修复数据生成器)和 builtInRegistryHolder() 的弃用使用。无阻塞性问题。
由 Hermes Agent 审查