Repository navigation
Conversation
Previous review (2026-10-24)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head The new Vehicle and Outputs sections work for the common Copter, Plane, Rover and Sub cases, and the value tables match ArduPilot's parameter metadata, but a few things should be fixed first. Should fix
Minor (2)
|
03d705f to
052e532
Compare
Previous review (2026-10-24)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head No blocking issues at Minor (3)
|
052e532 to
13c31ff
Compare
Previous review (2026-10-24)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head No blocking issues at Minor (1)
|
13c31ff to
ca75390
Compare
|
Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head No blocking or actionable issues at Minor (1)
|
Fixes #242.
FRAME_CLASS/FRAME_TYPEfor Copter and Rover,Q_FRAME_CLASS/Q_FRAME_TYPEfor QuadPlane,FRAME_CONFIGfor Sub). Plane shows "QuadPlane" whenQ_ENABLEis set, with "tilt-rotor" / "tailsitter" fromQ_TILT_ENABLE/Q_TAILSIT_ENABLE.SERVOn_FUNCTIONthat is not disabled, with its name. An extra column shows outputs also sent as DroneCAN ESC or servo (CAN_Dx_UC_ESC_BM/CAN_Dx_UC_SRV_BM), counting only drivers assigned to a port (CAN_Px_DRIVER) withCAN_Dx_PROTOCOL= DroneCAN. The column is hidden when nothing is on CAN.Value names are in a new
param_values.json, taken from the currentapm.pdef.jsonfor Copter, Plane, Rover and Sub, plus output function names for Antenna Tracker and Blimp. Function names are kept per vehicle because a few differ (e.g. Plane'sMotor7/TailTiltServo). A param file has no vehicle type, so it only gets the Outputs section, using the generic names.Checked on two Copter logs. The Plane, QuadPlane (tilt and tailsitter), Rover, Sub and CAN cases were checked by calling the functions with test params, as I have no logs for those.