Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Warn if lots of missing data" from #10.
For raw IMU logs, each gyro's info now shows "Missing data: N% of analysis time" when more than 10% of the analysis time has no usable data. Coverage comes from the batches the raw loader already splits at gaps (so dropped chunks of fewer than 64 samples also count as missing), clipped to the analysis time and to that gyro's data range. It updates on load and on every Calculate.
Batch logs are not checked. The batch sampler waits and retries when the log buffer is full rather than dropping data (
BatchSampler.cpp, "maybe later"), so gaps there aren't lost data.The 10% threshold is a guess (
missing_data_warn_fraction), happy to change it.Tested with a SITL raw IMU log, and a copy of it with 20 s of
GYRremoved mid hover to stand in for dropped messages. The original shows no warning. The copy shows 26% for the default analysis time and 37% for the 56 to 110 s hover (20 s of 54). No warning on batch logs.