Skip to content

PIDReview: show rise time, overshoot and settling time of step response - #377

Open
j-w9 wants to merge 1 commit into
ArduPilot:mainfrom
j-w9:pid-review-step-stats
Open

j-w9 wants to merge 1 commit into
ArduPilot:mainfrom
j-w9:pid-review-step-stats

Conversation

@j-w9

@j-w9 j-w9 commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

"Settling time read out. also other stats overshoot ect." from #92.

A table under the Step Response title gives, for the mean response of each test: rise time (10 to 90%), peak and peak time, overshoot, settling time (5% band) and final value.

  • The last 0.1 s of the estimate is ignored, because it turns up at the end (visible in the screenshot). Stats use 0 to 400 ms, and the final value is the mean from 200 to 400 ms.
  • If the final value is outside 0.5 to 1.5, only the final value is shown, as the other numbers would be misleading. On one of my logs the mean settles at 0.21.
  • Overshoot is left blank if the peak is inside the final value window, i.e. the response is still rising. Settling shows "> 400 ms" if it hasn't settled by then.
  • Stats are taken once per test after the batch loop. The mean plot is updated on each batch, so only the final mean is used.

The calculation matches an independent Python version on three analytic second order responses (damping 0.3/0.5/0.8). For damping 0.5 it gives 16.4% overshoot with the peak at 90 ms, against theory's 16.3% at 90.7 ms. The thresholds (step_stats_*) are easy to change if you'd prefer other definitions. No change to the step estimate itself.

Step response stats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant