refactor(server): vendor token bucket rate limiter from phoenix-evals#12430
Merged
RogerHYang merged 4 commits intomainfrom Mar 29, 2026
Merged
refactor(server): vendor token bucket rate limiter from phoenix-evals#12430RogerHYang merged 4 commits intomainfrom
RogerHYang merged 4 commits intomainfrom
Conversation
Vendor AdaptiveTokenBucket and RateLimiter into src/phoenix/server/rate_limiters.py to decouple arize-phoenix from arize-phoenix-evals. This is the first step toward removing the evals dependency from pyproject.toml. Key changes: - Copy AdaptiveTokenBucket and RateLimiter from phoenix-evals into server module - Add async_on_rate_limit_error() using asyncio.sleep instead of time.sleep to avoid blocking the event loop in the server's async context - Update playground_clients.py to import RateLimiter from server module - Add comprehensive tests for the vendored implementation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
dosubot
Bot
added
the
size:XL
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
RogerHYang
approved these changes
Mar 29, 2026
Contributor
RogerHYang
left a comment
RogerHYang
left a comment
There was a problem hiding this comment.
Can you also update pyproject.toml to remove the dependency?
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This reverts commit 0c7c372.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #12330
Summary
AdaptiveTokenBucketandRateLimiterfromphoenix-evalsintosrc/phoenix/server/rate_limiters.py, decoupling the server from the evals packageasync_on_rate_limit_error()usingasyncio.sleepinstead oftime.sleepto avoid blocking the event loop in the server's async contextplayground_clients.pyto import from the server-local modulearize-phoenix-evalsfrompyproject.tomldependenciesTest plan
uv run pytest tests/unit/server/test_rate_limiters.py -q— all vendored rate limiter tests passuv run pytest tests/unit/server/api/helpers/test_playground_clients.py -q— playground client tests passuv run ruff check— no lint issuesuv run mypy src/phoenix/server/rate_limiters.py— type checks pass