Refactor scripts and enhance OS detection functionality - #8
Open
hadeyghoptey wants to merge 2 commits into
Open
Conversation
…uirements and enhance OS detection
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves the XSS fuzzing utility’s robustness by refactoring CLI flow into a main(), hardening request handling, and making URL/query manipulation and validation more reliable.
Changes:
- Refactors
xssFuzz.pyscript execution intobuild_parser()+main()and improves CLI validation. - Reworks query parameter replacement/parsing using
urllib.parseutilities and adds request timeouts +Nonehandling. - Updates Selenium validation to better locate Chromium/Chromedriver and ensures the browser is always quit.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| xssFuzz.py | Adds main() entrypoint + CLI validation, safer request handling, and more robust URL query manipulation. |
| validate.py | Improves Chrome/Chromium and chromedriver discovery and ensures driver cleanup. |
| requirements.txt | Adds missing runtime dependency (requests). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+60
to
+62
| path = Path(filename) | ||
| if not path.is_absolute(): | ||
| path = BASE_DIR / path |
Comment on lines
+412
to
+414
| def convert_to_dict(header_string): | ||
| pairs = re.findall(r'([^,:\s]+):\s*([^,]+)', header_string) | ||
| return {key.strip(): value.strip() for key, value in pairs} |
Comment on lines
+85
to
+86
| #print(headers) | ||
| #print(url) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…uirements and enhance OS detection