CI: fix docs-deploy Node version for Astro build#111
Merged
Conversation
The deploy workflow ran the library build (webpack, Node 20) and the Astro website build in the same job under node-version 20, causing Astro to fail with "Node.js v20 is not supported". A single job can only run one Node version, so split the build job: - build-library (Node 20): builds the webpack bundle and uploads it as a GitHub Actions artifact - build-website (Node 22): downloads the bundle, copies it into website/public/, installs website deps, builds the Astro site, and uploads the Pages artifact - deploy: now depends on build-website (unchanged otherwise) 🤖 Generated with [eca](https://eca.dev) Co-Authored-By: eca <git@eca.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs-deploy.ymlworkflow ran both the library (webpack) build and the Astro website build inside the same job undernode-version: 20, causing Astro to fail: "Node.js v20 is not supported by Astro! Please upgrade to >=22.12.0"buildjob has been split into two:build-library(Node 20): compiles the webpack bundle and uploads it as a workflow artifactbuild-website(Node 22): downloads the bundle, copies it towebsite/public/, installs website deps, builds the Astro site, and uploads the Pages artifactdeploynow depends onbuild-websiteinstead of the oldbuildjob — no other changesTest plan
build-libraryjob passes on Node 20build-websitejob passes on Node 22deployjob successfully deploys to GitHub Pages🤖 Generated with eca