Skip to content

feat(contest-table): add AWC0100 EDPC-format provider#3716

Merged
KATO-Hiro merged 4 commits into
stagingfrom
#3691
Jun 24, 2026
Merged

feat(contest-table): add AWC0100 EDPC-format provider#3716
KATO-Hiro merged 4 commits into
stagingfrom
#3691

Conversation

@KATO-Hiro

@KATO-Hiro KATO-Hiro commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

close #3691

Summary by CodeRabbit

  • New Features

    • AtCoder Weekday Contest の表示に、0001〜0099 と 0100 を分けて対応できるようになりました。
    • 0100 用の問題一覧が追加され、A〜O の15問を表示できます。
  • Bug Fixes

    • 範囲指定の表示で、0100 が 0001〜0099 側に混ざらないようになりました。
    • 境界付近のコンテスト一覧が、重複なく正しく分かれるようになりました。
  • Documentation

    • 追加手順ガイドを更新し、テスト観点や並び順の注意点を明確にしました。

KATO-Hiro and others added 3 commits June 24, 2026 06:40
…001OnwardsProvider to AWC0001To0099Provider

AWC0100 (special edition, 15 tasks A-O) uses EDPC display format (no header, no round label, task index shown).
Existing AWC provider narrowed to 0001-0099 range. Provider key collision avoided via section parameter.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…h completion

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@KATO-Hiro, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 6 minutes and 11 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fe9b5ce4-a5b2-4655-baf8-da4ca33c07dd

📥 Commits

Reviewing files that changed from the base of the PR and between 0c2bc7f and c1ffdbd.

📒 Files selected for processing (1)
  • docs/guides/how-to-add-contest-table-provider.md
📝 Walkthrough

Walkthrough

AWC0001OnwardsProviderAWC0001To0099Provider(ラウンド 1–99 限定)と AWC0100Provider(contest_id 完全一致・EDPC 形式・15 問 A–O)に分割。prisma シード・フィクスチャ・単体テスト・グループ登録・ガイドドキュメントをすべて新構成に更新する。

Changes

AWC プロバイダ分割

Layer / File(s) Summary
AWC0001To0099Provider / AWC0100Provider 実装
src/features/tasks/utils/contest-table/awc_provider.ts
AWC0001OnwardsProviderAWC0001To0099Provider(フィルタ上限 contestRound <= 99・メタデータ更新)に置換。新規 AWC0100Provider を追加し、contest_id === 'awc0100' 限定フィルタ・provider key '0100'・常に空文字を返す getContestRoundLabel を実装。
フィクスチャ・シードデータ追加
prisma/tasks.ts, src/features/tasks/fixtures/contest-table/contest_table_provider.ts
prisma/tasks.tsawc0100 の問題レコード A〜O を追加。フィクスチャのエクスポート名を taskResultsForAWC0001To0099Provider に変更し、taskResultsForAWC0100Provider(15 問)を新設。
プロバイダ単体テスト・グループテスト更新
src/features/tasks/utils/contest-table/awc_provider.test.ts, src/features/tasks/utils/contest-table/contest_table_provider_groups.test.ts
AWC0001To0099Provider の境界フィルタ(awc0100 除外)・メタデータ・ラベルを検証。AWC0100Provider の 15 問フィルタ・空文字ラベル・EDPC 表示設定テストを追加。グループテストはサイズ 2 に更新し section 指定の有無でプロバイダクラスをアサート。
グループ登録・ドキュメント更新
src/features/tasks/utils/contest-table/contest_table_provider_groups.ts, docs/guides/how-to-add-contest-table-provider.md, .claude/skills/add-contest-table-provider/instructions.md
AWC0001Onwards グループに 2 プロバイダを addProvider チェーンで登録。ガイドの範囲フィルタ表・テスト例・addProvider 順序注意セクションを追記・更新。

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🏆 0001 から 0099、キッパリ線引き!
0100 は EDPC 形式で単独デビュー 🎉
addProvider の順番、忘れずに先頭から ☝️
15 問 A〜O、シードに刻まれた証 📝
分割統治で、AWC テーブル完全制覇 ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed タイトルはAWC0100のEDPC形式プロバイダ追加という主変更を簡潔に示しています。
Linked Issues check ✅ Passed #3691の目的であるAWC0100をEDPC形式で表示する対応が、実装とテストで満たされています。
Out of Scope Changes check ✅ Passed 追加されたドキュメント更新や既存AWC分割は、AWC0100対応と競合回避に必要な範囲内です。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch #3691

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/guides/how-to-add-contest-table-provider.md`:
- Around line 373-378: markdownlint MD031 is triggered by the fenced code block
in the “範囲フィルタ型” section because there is no blank line before and after the
fence. Update the markdown in that section to insert an empty line between the
explanatory sentence and the opening triple backticks, and another empty line
after the closing fence, keeping the surrounding list/item text intact so the
docs lint cleanly.

In `@src/features/tasks/fixtures/contest-table/contest_table_provider.ts`:
- Around line 885-899: The fixture list currently uses multiple snake_case
variables like awc0100_a through awc0100_o, which violates the camelCase
variable naming rule. Update the related declarations in contest_table_provider
to use a single camelCase array variable (or equivalent camelCase grouping) and
adjust the references in the same fixture block so the data remains identical
while removing the repeated snake_case variables.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0b2d758e-30e6-4535-9885-f389f3b07035

📥 Commits

Reviewing files that changed from the base of the PR and between 1a3645a and 0c2bc7f.

📒 Files selected for processing (8)
  • .claude/skills/add-contest-table-provider/instructions.md
  • docs/guides/how-to-add-contest-table-provider.md
  • prisma/tasks.ts
  • src/features/tasks/fixtures/contest-table/contest_table_provider.ts
  • src/features/tasks/utils/contest-table/awc_provider.test.ts
  • src/features/tasks/utils/contest-table/awc_provider.ts
  • src/features/tasks/utils/contest-table/contest_table_provider_groups.test.ts
  • src/features/tasks/utils/contest-table/contest_table_provider_groups.ts

Comment thread docs/guides/how-to-add-contest-table-provider.md
Comment thread src/features/tasks/fixtures/contest-table/contest_table_provider.ts
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@KATO-Hiro KATO-Hiro left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KATO-Hiro KATO-Hiro merged commit e49a491 into staging Jun 24, 2026
3 checks passed
@KATO-Hiro KATO-Hiro deleted the #3691 branch June 24, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] テーブル・AWC0100 を EDPC 形式で表示できるか調査しましょう

1 participant