Skip to content

audioreach-driver: q6apm_audio_pkt: remove q6apm_audio_is_adsp_ready() call from probe - #68

Merged
quic-aditrath merged 1 commit into
AudioReach:masterfrom
sauravk-git:remove-adsp-ready-call
Jul 31, 2026
Merged

audioreach-driver: q6apm_audio_pkt: remove q6apm_audio_is_adsp_ready() call from probe#68
quic-aditrath merged 1 commit into
AudioReach:masterfrom
sauravk-git:remove-adsp-ready-call

Conversation

@sauravk-git

@sauravk-git sauravk-git commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Remove q6apm_audio_is_adsp_ready() call from probe to avoid unwanted wait time.

CRs-Fixed: 4588877

@sauravk-git
sauravk-git requested review from a team July 28, 2026 10:57
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@sauravk-git
sauravk-git force-pushed the remove-adsp-ready-call branch from fa63892 to 55b5e79 Compare July 28, 2026 11:00
@sauravk-git
sauravk-git deleted the remove-adsp-ready-call branch July 28, 2026 11:06
@sauravk-git
sauravk-git restored the remove-adsp-ready-call branch July 28, 2026 11:07
@sauravk-git sauravk-git reopened this Jul 28, 2026
During boot, the q6apm_audio_is_adsp_ready() call in the probe path
triggers a synchronous APM_CMD_GET_SPF_STATE command to the DSP. If
the DSP is not yet up, this results in a 2-second timeout stall,
delaying the driver initialization unnecessarily. Since the DSP
readiness check is not a hard requirement at probe time, remove this
call to avoid the boot-time delay.

Signed-off-by: Saurav Kumar <sauravk@qti.qualcomm.com>
@sauravk-git
sauravk-git force-pushed the remove-adsp-ready-call branch from 55b5e79 to e264d01 Compare July 28, 2026 11:14

@mohsRafi mohsRafi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nandamajay nandamajay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sauravk-git

Copy link
Copy Markdown
Contributor Author

@quic-aditrath @qti-sbojja , please help review/merge this

@quic-aditrath
quic-aditrath merged commit 9a003d1 into AudioReach:master Jul 31, 2026
15 of 16 checks passed
@qswat-orbit-external

Copy link
Copy Markdown

Change task cannot be moved to Dev Complete

CR: 4588877
Change Task: audio-core.lnx.0.0
Error: GenAI Assisted field must be set before moving change tasks to Development Complete. Please provide GenAI information.

The change task for this CR cannot be automatically moved to Dev Complete due to the error above. Please resolve the issue mentioned in the error and manually change the change task status to Dev Complete in Orbit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants