fix(web): make signup resumable after incomplete account creation#14530
Merged
Conversation
|
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14530.audius.workers.dev Unique preview for this PR (deployed from this branch). |
5 tasks
raymondjacobson
added a commit
that referenced
this pull request
Jul 20, 2026
## Summary - show a retryable failure state when native account creation fails - resume Identity-only accounts at handle selection and indexed incomplete accounts at profile completion - preserve guest password recovery without advancing when the user edits their handle - use the exported common route namespace so the shared web helper typechecks in mobile Follow-up to #14530. ## Test plan - [x] Mobile TypeScript check - [x] Web TypeScript check - [x] Mobile focused Jest tests (7 tests) - [x] Web sign-on route Vitest tests (4 tests) - [x] ESLint on all touched files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Signup commits Identity credentials before submitting the core CreateUser write. When the chain or relay is unavailable, Identity reserves the email but the core user is never created. The existing incomplete-account recovery path still targeted legacy page state, which the current router ignored and redirected back to email entry. The create-user catch also swallowed its error, allowing the confirmation success callback to run afterward.
Test plan