feat: Update proteinfold output files to capture structures in cif format (SBP-451)#104
Open
minh-biocommons wants to merge 3 commits into
Open
feat: Update proteinfold output files to capture structures in cif format (SBP-451)#104minh-biocommons wants to merge 3 commits into
minh-biocommons wants to merge 3 commits into
Conversation
vtnphan
requested changes
Jul 17, 2026
vtnphan
left a comment
vtnphan
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, just wait for the confirmation whether we should keep the regex for CIF in alphafold2 and colabfolb tool.
| return classify_proteinfold_output_key( | ||
| key, | ||
| pdb_pattern=rf"/alphafold2/split_msa_prediction/top_ranked_structures/{sample_id_pattern}\.pdb", | ||
| pdb_pattern=rf"/alphafold2/split_msa_prediction/top_ranked_structures/{sample_id_pattern}\.(?:cif|pdb)", |
Collaborator
There was a problem hiding this comment.
You might need to ask Tom whether CIF is in alphafold2 and colabfold?
Collaborator
Author
There was a problem hiding this comment.
confirmed with Tom and they're not needed
vtnphan
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
SBP-451: Update proteinfold output files to capture structures in cif format
Type of change
Checklist