Show Loading text when palette has nothing to display#45
Draft
aswasif007 wants to merge 1 commit into
Draft
Conversation
The recent shift to an in-input spinner left the empty-state slot showing the regular "No results found." / "No matching options." / "No options available for X." copy even while the resolver was still in flight. When there's nothing else on screen, that copy is wrong — it tells the user the resolver returned no results when in fact it hasn't returned yet. Thread a `resolving` flag into `CommandListContent` and use it to swap the empty-state copy for "Loading..." while a resolve is pending. Items remain visible whenever they exist, so this only takes effect when the list is otherwise empty. Co-Authored-By: Agent Rico
shekharnwagh
approved these changes
May 11, 2026
Contributor
shekharnwagh
left a comment
shekharnwagh
left a comment
There was a problem hiding this comment.
I know this isn't marked ready for review, but tested it and it looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the "Loading..." copy in the palette's empty slot while a resolver is in flight, addressing review feedback on #39 (discussion r3217198070).
After the in-input spinner change in #39, the empty state still rendered the regular "No results found." / "No matching options." / "No options available for X." text even when the resolver was still pending. When nothing else is on screen, that copy is misleading — it implies the resolver finished with zero results when in fact it hasn't returned yet.
What changed
resolving: booleanprop throughCommandListContent.Testing
pnpm lintpnpm format:checkpnpm test(135 tests pass; new test asserts the empty slot shows "Loading..." when the user filters all commands out while a resolve is pending)pnpm build