Skip to content

AI Sidebar: Hide legacy toolbar when replacement is active#49219

Open
t-wright wants to merge 5 commits into
trunkfrom
jetpack-sidebar/hide-legacy-ai-toolbar
Open

AI Sidebar: Hide legacy toolbar when replacement is active#49219
t-wright wants to merge 5 commits into
trunkfrom
jetpack-sidebar/hide-legacy-ai-toolbar

Conversation

@t-wright

@t-wright t-wright commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of FORNO-335

Proposed changes

  • Hide the legacy Jetpack AI Assistant block toolbar extensions when Jetpack AI Sidebar block transformations are active.

Related product discussion/links

  • Companion Calypso branch: jetpack-sidebar/add-big-sky-toolbar-button.

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • Install Jetpack Beta on a Jurassic Ninja site and choose this branch
  • Enable the extension:
    • In ~/htdocs/wp-content/plugins/jetpack-dev/extensions/plugins/ai-assistant-plugin/ai-sidebar/class-jetpack-ai-sidebar.phpL538, edit this 'blockToolbarButton' => true
  • Select paragraph block
  • Confirm the legacy Jetpack AI Assistant toolbar button is not shown.
  • Open a non-post editor surface, such as the page editor, and confirm the legacy toolbar controls are not suppressed by this branch.

@github-actions

github-actions Bot commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the jetpack-sidebar/hide-legacy-ai-toolbar branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack jetpack-sidebar/hide-legacy-ai-toolbar

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added [Extension] AI Assistant Plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress [Tests] Includes Tests labels May 28, 2026
@github-actions

github-actions Bot commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: July 7, 2026
    • Code freeze: July 6, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 28, 2026
@jp-launch-control

jp-launch-control Bot commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 3 files.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/extensions/blocks/ai-assistant/extensions/lib/can-ai-assistant-be-enabled.ts 0/16 (0.00%) 0.00% 2 ❤️‍🩹
projects/plugins/jetpack/extensions/plugins/ai-assistant-plugin/ai-sidebar/class-jetpack-ai-sidebar.php 140/163 (85.89%) 1.12% 0 💚
projects/plugins/jetpack/extensions/plugins/ai-assistant-plugin/ai-assistant-plugin.php 31/38 (81.58%) 31.58% -12 💚

Full summary · PHP report · JS report

@t-wright t-wright mentioned this pull request May 28, 2026
Open
10 tasks
@t-wright t-wright marked this pull request as ready for review May 28, 2026 07:21
@t-wright t-wright force-pushed the jetpack-sidebar/hide-legacy-ai-toolbar branch from 01bfd3f to 95e51df Compare May 28, 2026 07:59
@t-wright t-wright force-pushed the jetpack-sidebar/hide-legacy-ai-toolbar branch from 95e51df to 028b836 Compare May 28, 2026 08:38
kat3samsin
kat3samsin previously approved these changes Jun 1, 2026
View reviewed changes

@kat3samsin kat3samsin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, works as expected!

Legacy Jetpack AI is not displayed when blockToolbarButton=true
Image

Disabled blockTransformations in jetpackAiSidebarPreview.features shows legacy Jetpack AI toolbar.
Image

@t-wright t-wright force-pushed the jetpack-sidebar/hide-legacy-ai-toolbar branch from a7b6d55 to 8cfb00b Compare June 12, 2026 04:41
t-wright added 4 commits June 24, 2026 12:22
@t-wright
AI Sidebar: Hide legacy toolbar when replacement is active
186bec0 
Mark the legacy AI Assistant toolbar extensions unavailable when Jetpack AI Sidebar block transformations are active. Prevents duplicate AI toolbar buttons while preserving the legacy controls whenever the sidebar entrypoint is gated off.
@t-wright
AI Sidebar: Rename block transformations flag
9adb07f 
Use the block transformations feature name for the sidebar availability flag so Jetpack and Calypso refer to the same capability consistently.
@t-wright
AI Sidebar: Gate legacy toolbar replacement
685eaf4 
Require the blockToolbarButton preview feature before exposing the sidebar replacement flag so preview/editorial review can run without hiding the legacy toolbar controls.
@t-wright
AI Sidebar: Gate toolbar replacement availability
89eb28a 
Explicitly marks the sidebar block transformations extension unavailable until its release flags are active. Prevents Jetpack from hiding the legacy toolbar before the replacement button is available.
@t-wright t-wright force-pushed the jetpack-sidebar/hide-legacy-ai-toolbar branch from 8cfb00b to 89eb28a Compare June 24, 2026 02:51
@t-wright
AI Sidebar: Gate legacy toolbar on the toolbar button alone
ab2c455 
Replaced the ai-sidebar-block-transformations extension with ai-sidebar-toolbar-button, so hiding the legacy AI toolbar is driven solely by whether its replacement button is live. Block transformations is becoming inherent agent behaviour with no real off state, so coupling the toolbar's visibility to it was a fiction that locked the two features in lockstep. Also deduplicated the post-editor/AI-features/preview checks through should_expose_sidebar().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kat3samsin kat3samsin kat3samsin left review comments

@iamchughmayank iamchughmayank Awaiting requested review from iamchughmayank

Assignees

No one assigned

Labels

[Block] AI Assistant [Extension] AI Assistant Plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Tests] Includes Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t-wright @kat3samsin