Skip to content

VideoPress: surface the admin dashboard in the Jetpack plugin#49696

Open
vianasw wants to merge 2 commits into
trunkfrom
add/jetpack-videopress-admin-ui
Open

VideoPress: surface the admin dashboard in the Jetpack plugin#49696
vianasw wants to merge 2 commits into
trunkfrom
add/jetpack-videopress-admin-ui

Conversation

@vianasw

@vianasw vianasw commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

The Jetpack > VideoPress admin dashboard has, until now, only ever appeared in the standalone Jetpack VideoPress plugin — even though the dashboard itself lives entirely in the automattic/jetpack-videopress package that the Jetpack plugin already bundles.

The reason is a single init option. The package's Admin_UI::init() only runs when Initializer::should_initialize_admin_ui() is true, which is only the case when a consumer passes admin_ui => true to $config->ensure( 'videopress', … ). The standalone plugin does that; Jetpack::configure() lumped 'videopress' into a bare loop that called $config->ensure( $feature ) with no options, so the flag was never set and the menu never registered.

This PR pulls 'videopress' out of that no-options loop and ensures it with array( 'admin_ui' => true ), mirroring the standalone plugin.

  • projects/plugins/jetpack/class.jetpack.php: ensure the videopress feature with admin_ui => true.

Behavior is unchanged unless the VideoPress module is active:

  • The page is still gated by Status::is_active(), which inside the Jetpack plugin means the VideoPress module must be active (Jetpack, unlike the standalone plugin, does not force-activate the module).
  • The existing rsm_jetpack_ui_modernization_videopress filter continues to select the UI: off → legacy React app, on → modernized wp-build dashboard. No new enablement mechanism is introduced.

All required assets (the legacy build/admin bundle and the full modernized build/ wp-build tree) and the jetpack-wp-build-polyfills dependency already ship in the Jetpack plugin's jetpack_vendor/ mirror, so no build changes are needed.

Related product discussion/links

  • VIDP-251 (modernized VideoPress dashboard) — this PR makes that dashboard reachable from the Jetpack plugin, not just the standalone plugin.

Does this pull request change what data or activity we track or use?

No. No new tracking is introduced. The package's existing Tracks usage is unchanged and still gated by the standard analytics/consent checks.

Testing instructions

Prerequisite: a site with the Jetpack plugin only (the standalone Jetpack VideoPress plugin deactivated), and the VideoPress module active (wp jetpack module activate videopress).

  1. Go to wp-admin → Jetpack. Confirm a VideoPress entry appears in the Jetpack submenu.
  2. Visit admin.php?page=jetpack-videopress.
    • With rsm_jetpack_ui_modernization_videopress off (default), the legacy React app renders (mount node #jetpack-videopress-root, jetpack-videopress-pkg bundle).
    • With the filter on (e.g. add_filter( 'rsm_jetpack_ui_modernization_videopress', '__return_true' );), the modernized wp-build dashboard renders (mount node #jetpack-videopress-dashboard-wp-admin-app, @wordpress/boot script module).
  3. With the VideoPress module inactive, confirm the page/menu does not appear (expected).

Verified locally in Docker with the standalone plugin deactivated: filter off → legacy app, filter on → modernized dashboard, both served by the Jetpack plugin alone.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/jetpack-videopress-admin-ui branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/jetpack-videopress-admin-ui

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jun 17, 2026
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: July 7, 2026
    • Code freeze: July 6, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jun 17, 2026
@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

vianasw and others added 2 commits June 26, 2026 14:55
The "Jetpack > VideoPress" dashboard previously appeared only in the
standalone Jetpack VideoPress plugin, which enables it by passing
`admin_ui => true` to `$config->ensure( 'videopress', ... )`. The main
Jetpack plugin ensured the 'videopress' feature without options, so the
admin_ui flag was never set and Admin_UI::init() never ran.

Pass `admin_ui => true` from Jetpack::configure() so the package's
Admin_UI initializes inside the Jetpack plugin too. The page still only
renders when the VideoPress module is active (Status::is_active()), and
the rsm_jetpack_ui_modernization_videopress filter continues to select
the legacy React app vs. the modernized wp-build dashboard.

Verified in local Docker with the standalone plugin deactivated: the
page renders the modernized dashboard with the filter on and the legacy
app with it off.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ment

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQbYMqwYS55EBaSNuHs8aD
@vianasw vianasw force-pushed the add/jetpack-videopress-admin-ui branch from 640d27d to 131a462 Compare June 26, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant