Renovate: update bundled wp package rules

[simison]

Follow-up to #49272 (review)

Latest bundled WP packages update revealed a few gaps.

Best to have #49272 merged first before this so that Renovate doesn't close it.

Proposed changes

• Includes @wordpress/theme to avoid mismatching versions of bundled deps (notably @wordpress/ui, @wordpress/dataviews, @wordpress/admin-ui and others) using style tokens from different version than Jetpack is shipping.
• Since we use @wordpress/stylelint-config to lint invalid design tokens, we need to bump that together with @wordpress/theme.
• Moves WP Build from its own section into Bundled WP section; this could be updated independently but for practical reasons testing steps and teams are basically the same as with the rest of the list, so worth combining. It can still be manually updated separately ahead of time when needed.
• Adds @wordpress/style-runtime from the latest bundled deps list

Related product discussion/links

• See Update Bundled @wordpress/* monorepo #49272

Does this pull request change what data or activity we track or use?

Testing instructions

• N/A

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[anomiex]

I like the general idea. Some comments inline.

I don't think this change would result in #49272 getting closed. Since the groupName isn't changing, it should still recognize it as the same change. I'll test that in a fork in a bit.

[anomiex]

Is this true? Looks like the actual rules are in @wordpress/theme, and @wordpress/stylelint-config just loads them from there.

[simison]

Hmm I'm not sure — I think that would work if @wordpress/stylelint-config would define @wordpress/theme as peer dependency, but it's a direct dependency so it likely uses its own version?

	"dependencies": {
		"@stylistic/stylelint-plugin": "^3.0.1",
		"@wordpress/theme": "^0.16.0",
		"stylelint-config-recommended": "^14.0.1",
		"stylelint-config-recommended-scss": "^14.1.0"
	},

I had exactly this mismatch happen after updating wp-theme+variables in JP locally to new ones, and stylelint started complaining it until I updated it. So I assumed stylelint was the issue but I did not confirm that. If you think it's safe to leave out, happy to do so.

[anomiex]

Hmm. Best thing in that case might be to pnpmfile-hack it to turn that into a peer dep. Or to >=0.16.0. 😀

Otherwise, I think it'd work fine for updating @wordpress/theme to something like 0.16.1, pnpm dedupe should take care of the indirect dep, but not 0.17.0 (because for 0.x caret deps like ^0.16.0, it works like >=0.16.0 <0.17.0).

[anomiex]

Maybe we should just merge that here too?

[simison]

My preference as well, and likely safer long-term, although right now anything using grid/dashboard stuff is non-production for at least another month.

@Automattic/red @Automattic/ventures WDYT if we merge the Dashboard renovate block added in #49815 with the Bundled WordPress deps? Might be more straightforward and safer with cross-dependencies.

[anomiex]

I don't think this change would result in #49272 getting closed. Since the groupName isn't changing, it should still recognize it as the same change. I'll test that in a fork in a bit.

Worked fine in my fork on anomiex#58, no deletion.