Support Node.js object URLs as image sources#2601
Merged
chearon merged 1 commit intoJul 13, 2026
Merged
Conversation
benitoalba
marked this pull request as ready for review
July 13, 2026 22:48
chearon
approved these changes
Jul 13, 2026
chearon
left a comment
chearon
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blob:nodedata:URLs throughresolveObjectURLWhy
Image#srconly recognized data and HTTP(S) URLs. Node.js object URLs therefore fell through to local path handling and were passed tofopen, soonloadnever fired and the image could not be drawn.Fixes #2525.
Testing
npx mocha test/image.test.js: 37 passing, 3 pendingnpm run lintnpm run tsdnpm test: 301 passing, 7 pending; two pre-existingCanvasPattern/CanvasGradientsave/restore failures on Windows also reproduce on unmodifiedmasterHave you updated CHANGELOG.md?