dev-env create: Update PHP 8.4 as the recommended#2846
Open
rebeccahum wants to merge 8 commits into
Open
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates VIP CLI dev-environment defaults to reflect PHP 8.3 as the recommended version when creating (and defaulting) dev environments.
Changes:
- Marks PHP 8.3 as “(recommended)” in the PHP image/label map.
- Reorders the PHP versions map so the default selection (derived from the first key) becomes PHP 8.3 instead of 8.2.
Comment on lines
30
to
33
| export const DEV_ENVIRONMENT_DEFAULT_PHP_VERSION = '8.3' as const; | ||
|
|
||
| export const DEV_ENVIRONMENT_PHP_VERSIONS: Record< string, PhpImage > = { | ||
| 8.2: { |
rebeccahum
force-pushed
the
dev-env/php83/recommended
branch
from
c5d8847 to
202aafc
Compare
rebeccahum
force-pushed
the
dev-env/php83/recommended
branch
from
202aafc to
d13ce08
Compare
Comment on lines
779
to
790
| result = DEV_ENVIRONMENT_PHP_VERSIONS[ version ].image; | ||
| result = | ||
| DEV_ENVIRONMENT_PHP_VERSIONS[ version as keyof typeof DEV_ENVIRONMENT_PHP_VERSIONS ].image; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@copilot apply changes based on this feedback
Contributor
There was a problem hiding this comment.
Addressed in d52adc4. resolvePhpVersion() now uses an own-property check so prototype-chain values like toString are rejected safely, and I added a regression test for that case. No UI changes were involved here, so there isn’t a screenshot to share.
Agent-Logs-Url: https://github.com/Automattic/vip-cli/sessions/747814a4-7b7c-47c4-a84c-5abd7d4a0c1b Co-authored-by: rebeccahum <16962021+rebeccahum@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Automattic/vip-cli/sessions/747814a4-7b7c-47c4-a84c-5abd7d4a0c1b Co-authored-by: rebeccahum <16962021+rebeccahum@users.noreply.github.com>
Contributor
|
we recommend 8.4 on the platform, should match that here as well. |
Contributor
Author
|
oyyyy its 8.4 now x_x kk on it |
…-cli into dev-env/php83/recommended
|
rebeccahum
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
W/ 8.2 EOL at the EOY, let's mark 8.4 as the recommended for dev-env creation.
Changelog Description
Changed
Pull request checklist
New release checklist
Steps to Test
Outline the steps to test and verify the PR here.
Example:
npm run build./dist/bin/vip-cookies.js nom