Add CI lint for JSON test fixture formatting#1286
Draft
jkmassel wants to merge 2 commits into
Draft
Conversation
Adds a `jq`-based check that all JSON test fixtures in `wp_api/tests/` and `test-data/` are pretty-printed with consistent 2-space indent. - `make fmt-check-json` — fails if any fixture isn't properly formatted - `make fmt-json` — auto-fixes all fixtures in place - Added to the `:rust: Lint` step in the Buildkite pipeline
Standardizes all JSON test fixtures to `jq .` output (2-space indent, no trailing whitespace, no BOM). This is a pure formatting change — no content was modified.
Collaborator
XCFramework BuildThis PR's XCFramework is available for testing. Add to your .package(url: "https://github.com/automattic/wordpress-rs", branch: "pr-build/1286")Built from f7bfb89 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a CI lint that validates all JSON test fixtures are consistently pretty-printed, and reformats existing fixtures to match.
Changes
scripts/check-json-formatting.sh:jq-based check/fix script for JSON fixture formatting (2-space indent, no BOM)Makefile:fmt-check-json(lint) andfmt-json(auto-fix) targets;fmt-check-jsonadded to thelintmeta-target.buildkite/pipeline.yml: Added the check to the:rust: Lintstepjq .output — pure formatting, no content changesTest plan
make fmt-check-jsonpasses locallymake fmt-jsonfixes intentionally-broken fixturescargo test --lib):rust: Lintstep passes