Open
Conversation
- New option added "Forum Attachment". - Menu Tree updated to handle new option. Now [img] will prompt: a) (If clipboard not empty) Paste URL b) From Library (from Camera has been removed) If From Library is selected, user can select their image. Once selected, another pair of options is presented: a) Image Host (if imgurUploadsEnabled) b) Forum Attachment - If image is too large (dimensions or filesize) (likely!) then option to Resize & Continue is presented. User can cancel out of resize to meet reqs. - Preview card UI element appears during resizing and also to display attachment thumbnail, dimensions and filesize in newreply view - Preview card with Keep or Delete segmented options present when editing a post with an attachment - Fixed existing issue where attachments would not render in posts. Had to download these with authentication and then display them in the posts after the html renders
…updated to follow. Support adding, replacing, and deleting attachments when editing posts. Adapts to forum changes that expanded edit capabilities: attachments can now be added to posts that didn't have them, and existing attachments can be replaced. The "Forum Attachment" option in the composition menu now appears for edits when the server supports it, gated by parsing the edit form for attachment controls. Also fixes attachment image display in posts by extracting attachmentid directly from img URLs instead of the nonexistent postid parameter, and fetches images in a single request instead of two. Disables the submit button while attachments are resizing.
Improved some of the BBCode tags to make populating them easier. Important: Branched from "attachments" to avoid conflicts with the menu item changes associated with Forum Attachments. Merge attachments into main before this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a second toolbar to composition view to contain BBCode helpers. These are the same options as the compositionMenuTree, but more easily available in an always visible toolbar.
Also, some of the BBCode tags have been improved to make populating them easier via modal inputs. e.g. [url] will present two fields: one for the URL to wrap in tags and an option to set a display value for the link.
Important: This has been branched from "attachments", not "main"! This was done to avoid conflicts with the menu item changes associated with Forum Attachments.
Merge "attachments" into main before this branch (please).