Add configurable T-SQL parser version and General settings tab#123
Open
alex-bochkov wants to merge 1 commit into
Open
Add configurable T-SQL parser version and General settings tab#123alex-bochkov wants to merge 1 commit into
alex-bochkov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TSqlParserorSql*ScriptGeneratoruse the configured parser version instead of hard-codedTSql170Parser/Sql170ScriptGenerator.Description
Generaltab to the settings UI with aComboBox(SqlVersion) andSavebutton to select and persist the parser version.TSqlParserVersionenum and helper methodsGetTSqlParserVersion(),SaveTSqlParserVersion()andGetTSqlParserVersionDisplayName()inSettingsManagerto store and present the option.TSqlParserFactorythat exposesCreate(bool initialQuotedIdentifiers)andCreateScriptGenerator()to return the correctTSqlParserandSqlScriptGeneratorfor the configured version.TSql170Parser/Sql170ScriptGeneratorwith calls toTSqlParserFactory.Create(...)andTSqlParserFactory.CreateScriptGenerator()in formatter, comment interleaver, object scripting, selection, and block-comment code paths, and add the new file to the project (AxialSqlTools.csproj).Testing
git diff --checkwhich passed without errors.rgsearches to ensure parser/generator usages were switched toTSqlParserFactoryand no remaining hard-codedTSql170Parser/Sql170ScriptGeneratorinstances remain in updated files.msbuildanddotnet buildbut both tools were not available in the environment so full compilation could not be executed here.Codex Task