fix(e2e): make fee_settings test resilient to fee decay#22583
Draft
AztecBot wants to merge 1 commit intomerge-train/fairiesfrom
Draft
fix(e2e): make fee_settings test resilient to fee decay#22583AztecBot wants to merge 1 commit intomerge-train/fairiesfrom
AztecBot wants to merge 1 commit intomerge-train/fairiesfrom
Conversation
AztecBot
added
ci-draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failure in
e2e_fees/fee_settings.test.tson merge-train/fairies.The test captured
stableMinFeesearly, then prepared two txs (takes time for proving). During this window, L2 fees naturally decayed due to low utilization. A single 20% bump was insufficient to bring fees back above the originally captured level.Fix:
bumpL2Fees()now accepts an optionalminTargetand loops — bumping proving cost by 20% each iteration — until fees exceed the target. Each 20% increment is small enough to stay under the 1.5x padding threshold.Full analysis: https://gist.github.com/AztecBot/a0d2cf5bccf8044345f37473510d21c6
ClaudeBox log: https://claudebox.work/s/395c6f5ae76e825e?run=1