Skip to content

Update README.md#4

Open
SKApretto71 wants to merge 2 commits into
Azure-Samples:mainfrom
SKApretto71:patch-1
Open

Update README.md#4
SKApretto71 wants to merge 2 commits into
Azure-Samples:mainfrom
SKApretto71:patch-1

Conversation

@SKApretto71

Copy link
Copy Markdown

Added a note as the script works only when English locale is used, because depends on text in output from utilities used.

Purpose

  • Will avoid errors running the script in other local - e.g. Italian, French, ... - as the script fails with errors that are not easy to identify as depending from the locale

Does this introduce a breaking change?

[ ] Yes
[X ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ X] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • In section "Script Dependencies" new test document the dependency from English as the language

Other Information

Added a note as the script works only when English locale is used, because depends on text in output from utilities used.
@SKApretto71 SKApretto71 closed this Dec 1, 2022
@SKApretto71 SKApretto71 reopened this Dec 1, 2022
@SKApretto71 SKApretto71 closed this Dec 6, 2023
@SKApretto71 SKApretto71 reopened this Dec 15, 2023
@SKApretto71

Copy link
Copy Markdown
Author

@mzmaili will you ever evaluate to add this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant