ci: Enhance deployment workflows and updated sample data import workflows#2116
Closed
Vamshi-Microsoft wants to merge 0 commit intoAzure-Samples:mainfrom
Closed
ci: Enhance deployment workflows and updated sample data import workflows#2116Vamshi-Microsoft wants to merge 0 commit intoAzure-Samples:mainfrom
Vamshi-Microsoft wants to merge 0 commit intoAzure-Samples:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request primarily removes the use of the
RESOURCE_TOKENparameter and related logic from several GitHub Actions workflows, simplifying resource cleanup and deployment processes. Additionally, it improves the PostgreSQL sample data import workflow by automatically discovering the PostgreSQL server in a resource group, eliminating the need for users to manually specify the host name.Key changes include:
Resource Token Removal and Cleanup Simplification:
RESOURCE_TOKENfrom workflow inputs, environment variables, and job steps in.github/workflows/job-cleanup-deployment.yml,.github/workflows/job-deploy-linux.yml, and.github/workflows/deploy-orchestrator.yml, including the logic for targeted resource cleanup within a resource group. Now, cleanup jobs only handle full resource group deletion. [1] [2] [3] [4] [5] [6] [7] [8]PostgreSQL Sample Data Import Workflow Improvements:
The PostgreSQL host name is no longer a required input; instead, the workflow now automatically discovers the first PostgreSQL Flexible Server in the specified resource group and uses it throughout the workflow. This change includes removing related input validation and updating all steps to use the discovered host. [1] [2] [3] [4] [5] [6] [7] [8] [9]
Added a step to download sample data from Azure Storage, storing it in a temporary directory for use in the data import process.
Resource Group Name Handling:
.github/workflows/deploy-v2.ymlto make theresource_group_nameinput optional, with an empty string as the default. The workflow now auto-generates a resource group name if not provided, and messaging has been updated accordingly. [1] [2] [3] [4]Other Minor Cleanups:
RESOURCE_TOKENinput from the Windows deployment workflow outputs.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information