test: add test for MIG mixed mode#8249
Merged
ganeshkumarashok merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
runzhen
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an e2e scenario to validate NVIDIA MIG mixed strategy behavior (resource-type-specific advertising like nvidia.com/mig-1g.10gb) on Ubuntu 24.04 GPU nodes, and updates the shared GPU scheduling validator to work with arbitrary GPU resource names.
Changes:
- Extend
ValidateGPUWorkloadSchedulableto accept aresourceNameparameter and use it for both readiness wait and pod resource limits. - Update existing GPU e2e scenarios to pass
"nvidia.com/gpu"explicitly. - Add a new Ubuntu 24.04 MIG Mixed scenario that validates MIG instance creation, resource advertising for
nvidia.com/mig-1g.10gb, and workload schedulability.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| e2e/validators.go | Generalize GPU workload scheduling validator to support MIG-specific resource names. |
| e2e/scenario_gpu_managed_experience_test.go | Update validator call sites and add a new MIG Mixed scenario covering MIG resource advertising + scheduling. |
| e2e/scenario_gpu_daemonset_test.go | Update daemonset scenario to use the new validator signature. |
ganeshkumarashok
approved these changes
Apr 8, 2026
timmy-wright
pushed a commit
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a test case for MIG mixed mode.
Which issue(s) this PR fixes:
Fixes #