Skip to content

feat: Add batch5 connectors (25 new connectors) + regenerate 17 existing#150

Merged
daviburg merged 1 commit into
Azure:mainfrom
daviburg:feature/generator-fixes-and-batch5
May 15, 2026
Merged

feat: Add batch5 connectors (25 new connectors) + regenerate 17 existing#150
daviburg merged 1 commit into
Azure:mainfrom
daviburg:feature/generator-fixes-and-batch5

Conversation

@daviburg
Copy link
Copy Markdown
Member

Summary

Adds 25 new connectors (batch5) and regenerates 17 existing connectors with the unified generator from the BPM DirectClient generator fixes.

New connectors (25)

Box, Docusign, Dropbox, Dynamicsax, Eventbrite, Ftp, Github, Googlecalendar, Googledrive, Googletasks, Jira, Mailchimp, Monday, Onedrive, Rss, Salesforce, Sendgrid, Slack, Sql, Trello, Twitter, Typeform, Webex, Wordpress, Zendesk

Regenerated existing connectors (17)

AzureMonitorLogs, Azuretables, Documentdb, ExcelOnlineBusiness, ExcelOnline, Infusionsoft, Office365, Office365Groups, Office365Users, OneDriveForBusiness, Pipedrive, Planner, Plumsail, Smtp, Wdatp, Yammer, AzureAD (via prior iterations)

Changes

  • 25 new *Extensions.cs\ files in \Generated/\
  • 17 updated *Extensions.cs\ files in \Generated/\
  • \ConnectorNames.cs: 25 new constants
  • \ManagedConnectors.cs: 25 new entries in \AvailableConnectors\
  • 25 new unit test files (*ClientTests.cs)

Test results

  • 786 tests pass, 0 failures (636 existing + 150 new)
  • All 18 ConnectorConstants sync tests pass (bidirectional validation)

Generator validation

All regenerated connector files produce byte-identical output when re-run through the corrected BPM DirectClient generator, confirming the generator fixes are complete and correct.

Related PR

@daviburg daviburg requested a review from a team as a code owner May 14, 2026 23:07
Copilot AI review requested due to automatic review settings May 14, 2026 23:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@daviburg daviburg self-assigned this May 14, 2026
@daviburg daviburg force-pushed the feature/generator-fixes-and-batch5 branch from 74c42e6 to 3000f78 Compare May 14, 2026 23:20
@daviburg daviburg requested a review from Copilot May 14, 2026 23:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

/// <summary>
/// The <c>github</c> connector.
/// </summary>
public const string Github = "github";
Copy link
Copy Markdown
Member Author

@daviburg daviburg May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the added const names appear to violate Pascal casing.
Github should be GitHub
Googlecalendar should be GoogleCalendar

etc.

@daviburg daviburg force-pushed the feature/generator-fixes-and-batch5 branch from 3000f78 to 188acb1 Compare May 14, 2026 23:43
Copilot AI review requested due to automatic review settings May 14, 2026 23:48
@daviburg daviburg force-pushed the feature/generator-fixes-and-batch5 branch from 188acb1 to 8bf815f Compare May 14, 2026 23:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

…nnectors

Regenerate all batch 5 connector clients using fixed CodefulSdkGenerator:
- Fix Optional<T> parameter wrapping for nullable types
- Fix Connector Namespace rebrand in generated code
- Fix PascalCase client/factory naming conventions
- Fix ServiceBusClient -> ServiceBusConnectorClient to avoid BCL conflict

Add 25 new connector clients (batch 5 expansion):
Box, Docusign, Dropbox, Dynamicsax, Eventbrite, Ftp, Github,
Googlecalendar, Googledrive, Googletasks, Jira, Mailchimp, Monday,
Onedrive, Rss, Salesforce, Sendgrid, Slack, Sql, Trello, Twitter,
Typeform, Webex, Wordpress, Zendesk

Fix pre-existing alphabetical ordering in ConnectorNames.cs and
ManagedConnectors.cs (AzureAutomation/AzureBlob, KeyVault/Kusto,
MicrosoftBookings/Mq, TextRequest/Todo).

Add unit tests for all 25 new connectors (constructor, dispose,
mocked API call, error handling, serialization round-trip, trigger
callback deserialization).

Total: 96 registered connectors, 786 tests passing.
@daviburg daviburg force-pushed the feature/generator-fixes-and-batch5 branch from 8bf815f to ade72d8 Compare May 15, 2026 00:04
@daviburg daviburg merged commit 537e392 into Azure:main May 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants