feat: add batch-5 connector samples#44
Draft
daviburg wants to merge 1 commit into
Draft
Conversation
…ntDB, EventHubs, ExcelOnlineBusiness, Outlook, ServiceBus, WordOnlineBusiness) - Add 8 new HTTP-triggered Azure Functions demonstrating each connector - Register all 8 clients in Program.cs - Fix pre-existing API compat issues: Teams ChannelId casing, MsGraph parameter name casing, SharePoint ListFolder API changes
There was a problem hiding this comment.
Pull request overview
Adds a new “batch-5” set of DirectConnector HTTP-triggered Azure Functions samples for additional Azure Connectors SDK clients, plus a few compatibility fixes for recent SDK API/name changes.
Changes:
- Added 8 new connector sample function classes (Azure Queues/Tables, Cosmos DB (DocumentDB), Event Hubs, Excel Online (Business), Outlook, Service Bus, Word Online (Business)).
- Registered the new connector clients in
DirectConnector/Program.csfor DI. - Updated a few existing samples to match SDK naming/API changes (Teams casing fixes, MS Graph named parameter casing, SharePoint folder API update).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| DirectConnector/AzureQueuesFunctions.cs | New Azure Queues sample endpoints (accounts + queues). |
| DirectConnector/AzureTablesFunctions.cs | New Azure Tables sample endpoints (accounts + tables). |
| DirectConnector/DocumentDbFunctions.cs | New Cosmos DB (DocumentDB) sample endpoints (accounts + databases). |
| DirectConnector/EventHubsFunctions.cs | New Event Hubs sample endpoints (event hubs + consumer groups). |
| DirectConnector/ExcelOnlineBusinessFunctions.cs | New Excel Online (Business) sample endpoints (sources + drives). |
| DirectConnector/OutlookFunctions.cs | New Outlook sample endpoints (calendars + contact folders). |
| DirectConnector/ServiceBusFunctions.cs | New Service Bus sample endpoints (queues + topics). |
| DirectConnector/WordOnlineBusinessFunctions.cs | New Word Online (Business) sample endpoints (sources + drives). |
| DirectConnector/Program.cs | Registers the new connector clients in DI. |
| DirectConnector/TeamsFunctions.cs | Updates Teams model property casing (ChannelId/MessageId). |
| DirectConnector/MsGraphFunctions.cs | Updates MS Graph named parameter casing for SDK compatibility. |
| DirectConnector/SharePointFunctions.cs | Updates ListFolder sample to use new folder-metadata APIs and adjusts response shape. |
| { | ||
| this._logger.LogInformation("AzureQueuesListQueues: Using generated AzurequeuesClient from SDK."); | ||
|
|
||
| var storageAccount = System.Web.HttpUtility.ParseQueryString(request.Url.Query)["storageAccount"]; |
| { | ||
| this._logger.LogInformation("AzureTablesGetTables: Using generated AzuretablesClient from SDK."); | ||
|
|
||
| var storageAccount = System.Web.HttpUtility.ParseQueryString(request.Url.Query)["storageAccount"]; |
| { | ||
| this._logger.LogInformation("DocumentDbGetDatabases: Using generated DocumentdbClient from SDK."); | ||
|
|
||
| var account = System.Web.HttpUtility.ParseQueryString(request.Url.Query)["account"]; |
| { | ||
| this._logger.LogInformation("EventHubsGetConsumerGroups: Using generated EventhubsClient from SDK."); | ||
|
|
||
| var eventHubName = System.Web.HttpUtility.ParseQueryString(request.Url.Query)["eventHub"]; |
| { | ||
| this._logger.LogInformation("ExcelOnlineBusinessGetDrives: Using generated ExcelOnlineBusinessClient from SDK."); | ||
|
|
||
| var location = System.Web.HttpUtility.ParseQueryString(request.Url.Query)["location"]; |
Comment on lines
+43
to
+50
| services.AddAzureQueuesClient(configuration.GetSection("Connectors:AzureQueues")); | ||
| services.AddAzureTablesClient(configuration.GetSection("Connectors:AzureTables")); | ||
| services.AddDocumentDbClient(configuration.GetSection("Connectors:DocumentDB")); | ||
| services.AddEventHubsClient(configuration.GetSection("Connectors:EventHubs")); | ||
| services.AddExcelOnlineBusinessClient(configuration.GetSection("Connectors:ExcelOnlineBusiness")); | ||
| services.AddOutlookClient(configuration.GetSection("Connectors:Outlook")); | ||
| services.AddServiceBusClient(configuration.GetSection("Connectors:ServiceBus")); | ||
| services.AddWordOnlineBusinessClient(configuration.GetSection("Connectors:WordOnlineBusiness")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 8 new HTTP-triggered Azure Functions demonstrating the batch-5 SDK connectors:
Pre-existing fixes included
E2E validated
All 8 connectors tested against the \sdk-test-gateway-prod\ Connector Namespace with \ unc start. Depends on SDK PR #146 (batch-5 connectors) being merged before updating the \Azure.Connectors.Sdk\ package reference version.