fix(designer): restore deploymentModelProperties for AzureOpenAI agent connections by takyyon · Pull Request #9108 · Azure/LogicAppsUX

takyyon · 2026-04-23T22:35:39Z

Commit Type

feature - New functionality
fix - Bug fix
refactor - Code restructuring without behavior change
perf - Performance improvement
docs - Documentation update
test - Test-related changes
chore - Maintenance/tooling

Risk Level

Low - Minor changes, limited scope
Medium - Moderate changes, some user impact
High - Major changes, significant user/system impact

What & Why

Regression from PR #9012 (merged April 6) which removed AzureOpenAI from the visibility dependencies of deploymentModelProperties in the agent loop manifest. This causes saving agent workflows with AzureOpenAI model type to fail with:

InvalidAgentModelSettings: The 'name' parameter value can't be null or empty for 'AzureOpenAI' model type.

PR #9012 assumed the backend derives model info from the deployment for AzureOpenAI. The backend does not — it requires deploymentModelProperties.name, .format, .version explicitly.

Root Cause

The manifest at agentloop.ts had its deploymentModelProperties fields (name, format, version) restricted to values: ['MicrosoftFoundry'] only. When agentModelType is AzureOpenAI, these fields were hidden by the conditional visibility system and never serialized.

Fix

Manifest (agentloop.ts): Restore AzureOpenAI in the visibility values array for all three deploymentModelProperties fields
parametersTab (both designer + designer-v2): Restore the deployment-info lookup for AzureOpenAI so model properties are auto-populated from the ARM deployment response when a user selects a deployment
Test: Added regression tests verifying deploymentModelProperties visibility includes both AzureOpenAI and MicrosoftFoundry

MicrosoftFoundry behavior is unchanged.

Impact of Change

Users: AzureOpenAI agent connections can be saved again. MicrosoftFoundry behavior unchanged.
Developers: No API changes.
System: No performance impact.

Test Plan

Unit tests added/updated
Manual testing completed
Tested in: agentloop.spec.ts (23/23 pass including 6 new regression tests)

Contributors

@takyyon

Screenshots/Videos

N/A

…t connections Regression from #9012 which removed AzureOpenAI from the visibility dependencies of deploymentModelProperties (name, format, version) in the agent loop manifest. The assumption was that the backend derives model info from the deployment — but the backend requires these values explicitly, failing with InvalidAgentModelSettings when they're missing. Changes: - Restore AzureOpenAI in agentloop.ts manifest visibility for deploymentModelProperties.name, .format, .version - Restore AzureOpenAI deployment-info lookup in parametersTab (both designer and designer-v2) so model properties are populated from the ARM deployment response when selecting a deployment - Add regression tests verifying deploymentModelProperties visibility includes both AzureOpenAI and MicrosoftFoundry Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-04-23T22:36:47Z

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

Current: fix(designer): restore deploymentModelProperties for AzureOpenAI agent connections
Issue: None — title is clear, scoped, and follows the conventional commit style.
Recommendation: Keep as-is. If you want to be extra explicit you can include the file/area changed (e.g., agentloop, parametersTab) but it's not required.

✅ Commit Type

Properly selected (fix).
Only one option is selected which is correct.

❌ Risk Level

Assessment: The PR body selects Medium risk, which is reasonable given UI + manifest changes and added tests. However, the repository PR labels do not include a risk label (expected risk:low, risk:medium, or risk:high). Every PR must have a matching risk label and the label must match the risk selected in the body.
Recommendation: Add the risk:medium label to this PR. If another reviewer or automation expects a different label, update the PR labels to match the body. If you believe the risk should be different, update the risk selection in the PR body to match the chosen label.

✅ What & Why

Current: Regression from PR fix(designer): Only populate deploymentModelProperties for MicrosoftFoundry #9012 removed AzureOpenAI visibility for deploymentModelProperties; restored AzureOpenAI in manifest visibility and added UI fix to populate deploymentModelProperties; tests added.
Issue: None — the description is concise, explains root cause and fix steps.
Recommendation: Keep the current content. It is clear and actionable.

✅ Impact of Change

No issues found: the impact section clearly indicates Users, Developers, and System impacts.
Recommendation: (optional) If you want to be more specific, mention which components or subsystems consume the agent loop manifest (e.g., designer, designer-v2) — but current content is adequate.

✅ Test Plan

Assessment: Unit tests added (agentloop.spec.ts), manual testing completed, and the PR body references the test file and counts.
Recommendation: Ensure CI passes and the new regression tests are included in the test run. The diff shows the new tests present, so this section is consistent with changes.

✅ Contributors

Assessment: Contributors section includes @takyyon which is fine.
Recommendation: Nothing required — credit is present.

✅ Screenshots/Videos

Assessment: N/A — no UI screenshots necessary for this kind of fix and you marked it N/A.
Recommendation: No change required.

Summary Table

Section	Status	Recommendation
Title	✅	Keep the current descriptive title.
Commit Type	✅	commit type set to `fix` — correct.
Risk Level	❌	Add `risk:medium` label to the PR to match body.
What & Why	✅	Good description — no action required.
Impact of Change	✅	Clear — no action required.
Test Plan	✅	Tests were added; ensure CI passes.
Contributors	✅	Contributor listed — OK.
Screenshots/Videos	✅	N/A is acceptable for this change.

Final Notes

The single actionable failure here is the missing risk label on the PR. Your selected risk level in the PR body is Medium, and the code changes (manifest + UI + tests) align with that risk assessment. Please add the repository label risk:medium to this PR so labels and body match. After adding the label, re-run any required status checks if your repo requires it.
Everything else looks good: title, commit type, WHAT/WHY, Impact, and Test Plan (unit test added) are all consistent with the change.

Please update the PR by adding the `risk:medium` label, ensure CI passes, and re-request review if needed. Thank you for the clear description and the included regression tests!

Last updated: Thu, 23 Apr 2026 22:36:46 GMT

Copilot

Pull request overview

Fixes a regression where AzureOpenAI agent connections could not be saved because deploymentModelProperties (name/format/version) were conditionally hidden and therefore not serialized/populated.

Changes:

Restores AzureOpenAI visibility dependencies for agentModelSettings.deploymentModelProperties.{name,format,version} in the agent loop manifest.
Updates Parameters Tab logic (designer + designer-v2) to populate deploymentModelProperties for AzureOpenAI as well as MicrosoftFoundry when a deployment is selected.
Adds unit coverage to prevent future regressions in manifest visibility conditions.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
libs/logic-apps-shared/src/designer-client-services/lib/standard/manifest/agentloop.ts	Re-adds `AzureOpenAI` to visibility dependencies for deployment model property fields so they can serialize.
libs/logic-apps-shared/src/designer-client-services/lib/standard/manifest/test/agentloop.spec.ts	Adds regression tests asserting visibility values include AzureOpenAI + MicrosoftFoundry (and exclude V2).
libs/designer/src/lib/ui/panel/nodeDetailsPanel/tabs/parametersTab/index.tsx	Populates `deploymentModelProperties` for AzureOpenAI on deployment selection.
libs/designer-v2/src/lib/ui/panel/nodeDetailsPanel/tabs/parametersTab/index.tsx	Same as above for designer-v2.

Copilot · 2026-04-23T22:40:12Z

+        // Populate deploymentModelProperties for both AzureOpenAI and MicrosoftFoundry.
+        // The backend requires name/format/version for AzureOpenAI model type.
+        if ((currentModelType === 'MicrosoftFoundry' || currentModelType === 'AzureOpenAI') && selectedModelId) {
          const deploymentInfo = deploymentsForCognitiveServiceAccount?.find((deployment: any) => deployment.name === selectedModelId);
-          const modelName = deploymentInfo?.properties?.model?.name;
+          const modelName = deploymentInfo?.properties?.model?.name ?? selectedModelId;


Since deploymentModelProperties are now required/populated for AzureOpenAI too, this handler can still end up with empty deploymentModelProperties when agentModelType switches away from MicrosoftFoundry (the earlier logic clears these fields whenever newValue !== 'MicrosoftFoundry'). Because this populate logic only runs when the deploymentId field changes, the cleared values may never be repopulated (e.g., if deploymentId remains unchanged / is set programmatically). Update the clearing condition to keep these fields for AzureOpenAI as well, or trigger repopulation based on the currently-selected deploymentId after model type changes.

Copilot · 2026-04-23T22:40:13Z

+        // Populate deploymentModelProperties for both AzureOpenAI and MicrosoftFoundry.
+        // The backend requires name/format/version for AzureOpenAI model type.
+        if ((currentModelType === 'MicrosoftFoundry' || currentModelType === 'AzureOpenAI') && selectedModelId) {
          const deploymentInfo = deploymentsForCognitiveServiceAccount?.find((deployment: any) => deployment.name === selectedModelId);
-          const modelName = deploymentInfo?.properties?.model?.name;
+          const modelName = deploymentInfo?.properties?.model?.name ?? selectedModelId;


Same issue as designer v1: deploymentModelProperties are now populated for AzureOpenAI here, but the earlier agentModelType-change handler still clears deploymentModelProperties whenever newValue !== 'MicrosoftFoundry'. Because this block only runs on a user change to deploymentId, those cleared values may not be repopulated (e.g., if deploymentId stays the same or is updated via dispatch). Adjust the clearing condition to exclude AzureOpenAI, and/or add a repopulation step when model type changes and a deployment is already selected.

github-actions · 2026-04-23T22:52:34Z

📊 Coverage Check

No source files changed in this PR.

Copilot AI review requested due to automatic review settings April 23, 2026 22:35

Copilot started reviewing on behalf of takyyon April 23, 2026 22:36 View session

github-actions Bot added the needs-pr-update label Apr 23, 2026

Copilot AI reviewed Apr 23, 2026

View reviewed changes

This was referenced Apr 25, 2026

[repo-status] Daily Repo Status — April 25, 2026 #9116

Closed

[repo-status] Daily Repo Status — April 29, 2026 #9122

Closed

[repo-status] Daily Repo Status — April 30, 2026 #9128

Closed

[repo-status] Daily Repo Status — May 1, 2026 #9133

Closed

This was referenced May 2, 2026

[repo-status] Daily Repo Status — May 2, 2026 #9134

Closed

[repo-status] Daily Repo Status — May 4, 2026 #9137

Closed

[repo-status] Daily Repo Status — May 6, 2026 #9140

Closed

[repo-status] Daily Repo Status — May 7, 2026 #9145

Closed

This was referenced May 16, 2026

[repo-status] Daily Repo Status — May 16, 2026 #9183

Closed

[repo-status] Daily Repo Status — May 17, 2026 #9184

Closed

[repo-status] Daily Repo Status — May 18, 2026 #9185

Closed

[repo-status] Daily Repo Status — May 19, 2026 #9190

Closed

github-actions Bot mentioned this pull request May 23, 2026

[repo-status] Daily Repo Status — May 23, 2026 #9212

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(designer): restore deploymentModelProperties for AzureOpenAI agent connections#9108

fix(designer): restore deploymentModelProperties for AzureOpenAI agent connections#9108
takyyon wants to merge 1 commit into
mainfrom
fix/agent-azureopenai-deployment-model-properties

takyyon commented Apr 23, 2026

Uh oh!

github-actions Bot commented Apr 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 23, 2026

Uh oh!

Copilot AI Apr 23, 2026

Uh oh!

github-actions Bot commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

takyyon commented Apr 23, 2026

Commit Type

Risk Level

What & Why

Root Cause

Fix

Impact of Change

Test Plan

Contributors

Screenshots/Videos

Uh oh!

github-actions Bot commented Apr 23, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

✅ Commit Type

❌ Risk Level

✅ What & Why

✅ Impact of Change

✅ Test Plan

✅ Contributors

✅ Screenshots/Videos

Summary Table

Please update the PR by adding the risk:medium label, ensure CI passes, and re-request review if needed. Thank you for the clear description and the included regression tests!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 23, 2026

📊 Coverage Check

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Please update the PR by adding the `risk:medium` label, ensure CI passes, and re-request review if needed. Thank you for the clear description and the included regression tests!