Skip to content

fix(designer-v2): change actiontype filter value from 'trigger' to 'triggers' #9130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lisajmeyer wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(designer-v2): change actiontype filter value from 'trigger' to 'triggers' #9130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff0cb4c
Change filter actionType values from 'trigger' to 'triggers'
lisajmeyer Apr 30, 2026
0c351dc
Merge branch 'main' into patch-1
lisajmeyer May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/designer-v2/src/lib/ui/panel/recommendation/browse/browseView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export const BrowseView = ({ isTrigger = false, onOperationClick }: BrowseViewPr
<ConnectorBrowse
categoryKey={selectedBrowseCategory.key}
connectorFilters={category.connectorFilters}
filters={{ actionType: isTrigger ? 'trigger' : 'action' }}
filters={{ actionType: isTrigger ? 'triggers' : 'actions' }}
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These string literals are part of a shared contract between BrowseView and ConnectorBrowse filtering. To prevent future regressions (e.g., singular/plural mismatches), strongly consider replacing the inline strings with a shared enum/union type or exported constants (e.g., ActionTypeFilter.Triggers / Actions) used by both the code that sets the filter and the code that interprets it.

Copilot uses AI. Check for mistakes.
displayRuntimeInfo={true}
onConnectorSelected={onConnectorSelected}
/>
Expand Down
Loading