-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: relax k8s-extension pinned dependencies
#9709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -31,8 +31,8 @@ | |||||
| ] | ||||||
|
|
||||||
| DEPENDENCIES = [ | ||||||
| "kubernetes==24.2.0", | ||||||
| "oras==0.2.25", | ||||||
| "kubernetes>=24.2.0", | ||||||
| "oras>=0.2.25", | ||||||
| ] | ||||||
|
|
||||||
| VERSION = "1.7.0" | ||||||
|
||||||
| VERSION = "1.7.0" | |
| VERSION = "1.7.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new dependency specifiers use unbounded lower ranges (e.g.,
kubernetes>=24.2.0,oras>=0.2.25). This can pull in future major (or fororas, even minor) releases that may introduce breaking API changes and cause the extension to fail at runtime. Consider using a compatible range with an upper bound (e.g.,>=24.2.0,<25.0.0/~=24.2.0, and fororassomething like>=0.2.25,<0.3.0) so installs remain predictable while still relaxing pins.