Fix: remove .enabled suffix from individual DML tool configure option#3408
Open
souvikghosh04 wants to merge 5 commits intomainfrom
Open
Fix: remove .enabled suffix from individual DML tool configure option#3408souvikghosh04 wants to merge 5 commits intomainfrom
souvikghosh04 wants to merge 5 commits intomainfrom
Conversation
#3373) The dab configure command used option names like --runtime.mcp.dml-tools.describe-entities.enabled which implied a nested object structure ({ describe-entities: { enabled: true } }). The schema expects direct booleans ({ describe-entities: true }). Removed the .enabled suffix from 7 individual DML tool option names in ConfigureOptions.cs. Added 3 test methods (5 test cases) covering individual, bulk, and multi-tool configure scenarios.
souvikghosh04
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dab configure CLI option names for individual MCP DML tools to match the runtime config schema by removing the incorrect .enabled suffix (e.g., runtime.mcp.dml-tools.describe-entities.enabled → runtime.mcp.dml-tools.describe-entities). This aligns CLI usage with the expected JSON shape for per-tool booleans under runtime.mcp.dml-tools.
Changes:
- Updated 7 MCP DML tool
ConfigureOptionslong option names to remove the.enabledsuffix. - Added unit tests validating that configuring individual tools and the bulk
runtime.mcp.dml-tools.enabledtoggle updates the runtime config as expected. - Added a multi-option test to ensure multiple per-tool updates apply independently.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Cli/Commands/ConfigureOptions.cs | Renames long option strings for individual MCP DML tool toggles to match schema paths (no .enabled suffix). |
| src/Cli.Tests/ConfigureOptionsTests.cs | Adds tests for per-tool and bulk MCP DML tool configuration updates. |
souvikghosh04
requested review from
Alekhya-Polavarapu,
Aniruddh25,
JerryNixon,
RubenCerna2079,
aaronburtle,
anushakolan,
rusamant,
sourabh1007,
stuartpa and
vadeveka
as code owners
Aniruddh25
reviewed
Apr 3, 2026
Aniruddh25
requested changes
Apr 3, 2026
Keep only E2E tests that verify CLI option name parsing via Program.Execute().
souvikghosh04
force-pushed
the
Usr/sogh/bug3373
branch
from
6783acb to
80dd1e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
dab configure individual DML tool options had an extra
.enabledsuffix, producing invalid nested config instead of the direct booleans the schema expects.What is this change?
Removed
.enabledsuffix from 7 individual DML tool names in ConfigureOptions.cs (e.g.,--runtime.mcp.dml-tools.describe-entities.enabledis nowruntime.mcp.dml-tools.describe-entities).Bulk toggle (
--runtime.mcp.dml-tools.enabled)How was this tested?
Sample Request(s)
Fixed: direct boolean, matches schema
dab configure --runtime.mcp.dml-tools.describe-entities trueMultiple tools
dab configure --runtime.mcp.dml-tools.describe-entities true --runtime.mcp.dml-tools.create-record false