Fix CLI overrides LogLevel value from config file#3426
Draft
RubenCerna2079 wants to merge 1 commit intomainfrom
Draft
Fix CLI overrides LogLevel value from config file#3426RubenCerna2079 wants to merge 1 commit intomainfrom
RubenCerna2079 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
Whenever we use the
dab startcommand the CLI overrides the minimum LogLevel from the configuration file. This is acceptable only if we use the--LogLevelflag. If we do not use that flag, the LogLevel for each namespace should be decided by the configuration file.What is this change?
This change moves the
args.Addmethods inside theConfigGenerator.csso that they are only applied when we use the--LogLevelflag. Having these arguments causes DAB to not allow any changes to the LogLevel in the loggers, since those arguments were always being added, DAB always assumed the CLI was overriding the LogLevel when it was not expect.How was this tested?
Sample Request(s)
dab start --LogLevel information
dab start (With config file default value debug)