Skip to content

[workers] Deprecate "jenkins-kvm-workers" and "jenkins-workers" tags #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daall wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[workers] Deprecate "jenkins-kvm-workers" and "jenkins-workers" tags #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jenkins/broadcom/buildimage-brcm-all-pr/Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pipeline {
agent { node { label 'jenkins-workers' } }
agent { node { label 'jenkins-build-workers' } }

options {
buildDiscarder(logRotator(artifactDaysToKeepStr: '', artifactNumToKeepStr: '', daysToKeepStr: '', numToKeepStr: '60'))
Expand Down
2 changes: 1 addition & 1 deletion jenkins/broadcom/buildimage-brcm-all-released-pr/Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pipeline {
agent { node { label 'jenkins-workers' } }
agent { node { label 'jenkins-build-workers' } }

options {
buildDiscarder(logRotator(artifactDaysToKeepStr: '', artifactNumToKeepStr: '', daysToKeepStr: '', numToKeepStr: '60'))
Expand Down
2 changes: 1 addition & 1 deletion jenkins/generic/buildimage-baseimage-pr/Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pipeline {
agent { node { label 'jenkins-workers' } }
agent { node { label 'jenkins-build-workers' } }

options {
buildDiscarder(logRotator(artifactDaysToKeepStr: '', artifactNumToKeepStr: '', daysToKeepStr: '', numToKeepStr: '60'))
Expand Down
2 changes: 1 addition & 1 deletion jenkins/mellanox/buildimage-mlnx-all-pr/Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pipeline {
agent { node { label 'jenkins-workers' } }
agent { node { label 'jenkins-build-workers' } }

options {
buildDiscarder(logRotator(artifactDaysToKeepStr: '', artifactNumToKeepStr: '', daysToKeepStr: '', numToKeepStr: '60'))
Expand Down
2 changes: 1 addition & 1 deletion jenkins/mellanox/buildimage-mlnx-all-released-pr/Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pipeline {
agent { node { label 'jenkins-workers' } }
agent { node { label 'jenkins-build-workers' } }

options {
buildDiscarder(logRotator(artifactDaysToKeepStr: '', artifactNumToKeepStr: '', daysToKeepStr: '', numToKeepStr: '60'))
Expand Down
2 changes: 1 addition & 1 deletion jenkins/vs/buildimage-vs-image-201904/Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pipeline {
agent { node { label 'jenkins-kvm-workers' } }
agent { node { label 'jenkins-build-workers' } }
Copy link
Copy Markdown
Contributor

@lguohan lguohan Jun 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to separate this job like what we did for builimage-vs-image before we change the tag.


options {
buildDiscarder(logRotator(artifactDaysToKeepStr: '', artifactNumToKeepStr: '', daysToKeepStr: '', numToKeepStr: '30'))
Expand Down
2 changes: 1 addition & 1 deletion jenkins/vs/buildimage-vs-image-201911/Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pipeline {
agent { node { label 'jenkins-kvm-workers' } }
agent { node { label 'jenkins-build-workers' } }
Copy link
Copy Markdown
Contributor

@lguohan lguohan Jun 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to separate this job like what we did for builimage-vs-image before we change the tag.

Copy link
Copy Markdown
Contributor Author

@daall daall Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we separating the job? There's no "Test" stage for any of these three jobs, so I'm not sure where the split should be,


options {
buildDiscarder(logRotator(artifactDaysToKeepStr: '', artifactNumToKeepStr: '', daysToKeepStr: '', numToKeepStr: '30'))
Expand Down
2 changes: 1 addition & 1 deletion jenkins/vs/buildimage-vs-image-released-pr/Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pipeline {
agent { node { label 'jenkins-kvm-workers' } }
agent { node { label 'jenkins-build-workers' } }
Copy link
Copy Markdown
Contributor

@lguohan lguohan Jun 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to separate this job like what we did for builimage-vs-image before we change the tag.


options {
buildDiscarder(logRotator(artifactDaysToKeepStr: '', artifactNumToKeepStr: '', daysToKeepStr: '', numToKeepStr: '60'))
Expand Down