[202412] Fix test_configurable_drop_counters.py for v6 topos#1019
Open
markx-arista wants to merge 2 commits into
Open
[202412] Fix test_configurable_drop_counters.py for v6 topos#1019markx-arista wants to merge 2 commits into
markx-arista wants to merge 2 commits into
Conversation
7 tasks
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @r12f could you please re-initiate the build? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
markx-arista
force-pushed
the
202412-fix-test-configurable-drop-counters-for-v6-topo
branch
from
54a067a to
6e416de
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fix test_neighbor_link_down for v6 topo Fix test_dip_link_local and test_sip_link_local for v6 topo, but skip them for Broadcom Asics because they don't support DIP_LINK_LOCAL/SIP_LINK_LOCAL drop reasons for IPv6 packets Signed-off-by: markxiao <markxiao@arista.com>
markx-arista
force-pushed
the
202412-fix-test-configurable-drop-counters-for-v6-topo
branch
from
6e416de to
dc72138
Compare
Originally these tests were skipped for only Broadcom ASICs on IPv6 topo. But DIP_LINK_LOCAL/SIP_LINK_LOCAL drop reasons are for IPv4 packets only as per SAI spec, so we need to skip them for everyone. Also revert V6 topo changes to the test cases. Signed-off-by: markxiao <markxiao@arista.com>
Author
|
Updated PR to include sonic-net/sonic-mgmt#22482 as well |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@yanmo96 can you please re-run the build? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fix test_neighbor_link_down for v6 topo and remove xfail
Skip test_dip_link_local and test_sip_link_local for v6 topo because DIP_LINK_LOCAL/SIP_LINK_LOCAL drop reasons are for IPv4 packets only as per SAI spec:
https://github.com/opencomputeproject/SAI/blob/v1.17.4/inc/saidebugcounter.h#L228
Manually cherry-pick of: sonic-net/sonic-mgmt#21763 and sonic-net/sonic-mgmt#22482
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
test_configurable_drop_counters.py failed on v6 topos
How did you do it?
Fix test cases for V6 topos, and skip test_dip_link_local/test_sip_link_local for V6 topo with Broadcom Asics
How did you verify/test it?
test_neighbor_link_down passed on V6 topos and test_dip_link_local/test_sip_link_local are skipped on V6 topos with Broadcom Asics
Any platform specific information?
Broadcom Asics don't support DIP_LINK_LOCAL/SIP_LINK_LOCAL drop reasons for IPv6 packets
Supported testbed topology if it's a new test case?
Documentation