fix(benchmark): exclude emit stage from compilation total#4528
Open
Copilot wants to merge 1 commit into
Open
Conversation
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
timotheeguerin
June 1, 2026 17:59
View session
timotheeguerin
approved these changes
Jun 1, 2026
Collaborator
|
No changes needing a change description found. |
Collaborator
|
You can try these changes here
|
markcowl
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark
totalmetric included emit time, meaning adding more emitters would inflate it — making it an unreliable signal for compiler performance regressions.Changes
packages/benchmark/src/run.ts: Always recomputeruntime.totalasloader + resolver + checker + validation + linter, unconditionally excludingemit.total. Previously, the total was only recomputed as a fallback when the compiler didn't set it, and even then included emit.Emit data is still captured in
stats.runtime.emitand surfaced in output tables — it's just no longer factored into thetotalcompilation metric.