Updating AKS MCP to v.0.0.17 and fixing WSL activation#2128
Merged
Conversation
Signed-off-by: tejhan-diallo <tejhan.diallo@gmail.com>
Signed-off-by: Tejhan Diallo <82427254+tejhan@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the AKS MCP server integration to use VS Code’s MCP server definition provider mechanism (to better support remote environments like WSL), and bumps the bundled AKS MCP server release tag to v0.0.17.
Changes:
- Register an
aks-mcpMCP server definition provider during extension activation instead of writingmcp.serversdirectly. - Remove the legacy “Setup AKS MCP Server” command and its quick action entry.
- Update the default
aks.aksmcpserver.releaseTagfromv0.0.16tov0.0.17.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/extension.ts | Registers the AKS MCP server provider on activation and removes the legacy setup command registration. |
| src/commands/quickActions/aksQuickActions.ts | Removes the MCP setup command from quick actions and simplifies grouping logic accordingly. |
| src/commands/aksMCP/aksMCPServer.ts | Replaces “write to user settings” behavior with an MCP server definition provider that resolves the binary on demand. |
| package.json | Adds contributes.mcpServerDefinitionProviders, bumps MCP release tag default to v0.0.17, and removes the legacy setup command contribution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tatsinnit
previously approved these changes
May 12, 2026
Tatsinnit
reviewed
May 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
src/commands/aksMCP/aksMCPServer.ts:25
- The provider doesn't expose an
onDidChangeMcpServerDefinitionsevent, so changes to theaks.aksmcpserver.enabledComponents(orreleaseTag) settings made after activation won't propagate to VS Code's MCP server list. Users will need to restart VS Code (or stop/start the server, since resolve recomputes args) for new component flags or a new release tag to take effect. Consider emitting that event when the relevant configuration sections change viavscode.workspace.onDidChangeConfiguration.
const provider: vscode.McpServerDefinitionProvider<vscode.McpStdioServerDefinition> = {
// Binary path left empty, resolveMcpServerDefinition sets it further below.
provideMcpServerDefinitions: () => [
new vscode.McpStdioServerDefinition("AKS MCP", "", ["--transport", "stdio", ...getEnabledComponentsArgs()]),
],
// Downloads binary then points the server at it.
resolveMcpServerDefinition: async (server) => {
const binary = await getAKSMCPServerBinaryPath();
if (failed(binary)) {
throw new Error(`Failed to download AKS MCP server: ${binary.error}`);
}
server.command = binary.result;
server.args = ["--transport", "stdio", ...getEnabledComponentsArgs()];
return server;
},
};
Signed-off-by: tejhan-diallo <tejhan.diallo@gmail.com>
Tatsinnit
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates our AKS MCP registration logic to use newly standardized
vscode.McpServerDefinitionProvider, bump to the most recentv.0.0.17version, and remedies failing installations on remote environments.registerMcpServerDefinitionProviderimplemnetation, which runs on the extension host the user is in (which properly captures remote environemnts)contributes.mcpServerDefinitionProviderstopackage.jsonaks.aksmcpserver.releaseTagfromv.0.0.16->v.0.0.17getEnabledComponentsArgshelper to pass the component with preservation of previous behaviorThe registration now automatically occurs on activation, and further installation/starting the server will remain user invoked as it was before.
Resolves