Wire onboarding telemetry hooks into AzureActiveDirectoryWebViewClient, Fixes AB#3462876

[wzhipan]

C3 in the onboarding telemetry feature series (follows merged #3088 / #3111 / #3117).

Adds optional onboarding-telemetry instrumentation to AzureActiveDirectoryWebViewClient so the WebView page-transition flow can populate the onboarding blob.

What this adds:

• setOnboardingTelemetryRecorder(recorder) setter on AzureActiveDirectoryWebViewClient — host fragment/activity attaches the recorder once a seed JSON arrives.
• Step emissions at the existing URL-dispatch sites (no behavior change to those paths):
  • processInstallRequest / processPlayStoreURL / processIntentToInstallBrokerApp → STEP_BROKER_INSTALL_PROMPTED
  • processDeviceCaRequest → STEP_MDM_ENROLLMENT_STARTED
  • launchCompanyPortal / processWebCpRequest → STEP_COMPANY_PORTAL_LAUNCHED
  • processWebCpEnrollmentUrl → STEP_WEB_CP_ENROLLMENT_STARTED
  • openGoogleEnrollmentUrl → STEP_GOOGLE_ENROLLMENT_STARTED
  • processAuthAppMFAUrl → STEP_AUTHENTICATOR_MFA_LINKING_STARTED
• onPageFinished captures the host of the final loaded URL into last_loaded_domain.

Safety: Recorder is @Nullable — when not attached (every existing caller, today), this is a no-op.

Tests: AzureActiveDirectoryWebViewClientTest covers all setter + emission paths.

Fixes AB#3462876

[github-actions]

✅ Work item link check complete. Description contains link AB#3462876 to an Azure Boards work item.

[github-actions]

❌ Work item link check failed. Description contains AB#3462876 but the Bot could not link it to an Azure Boards work item.

Click here to learn more.

[Copilot]

Pull request overview

Adds optional onboarding-telemetry instrumentation to AzureActiveDirectoryWebViewClient so WebView navigation events can populate the mobile onboarding telemetry blob used downstream (OneAuth/broker) for CA-blocked remediation funnels.

Changes:

• Adds an optional OnboardingTelemetryRecorder setter to AzureActiveDirectoryWebViewClient and emits onboarding step IDs at key URL-dispatch points.
• Records the host of loaded pages into the onboarding blob as last_loaded_domain from onPageFinished.
• Adds/updates unit tests and a changelog entry for the new onboarding telemetry hooks.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
common/src/main/java/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java	Adds nullable recorder attachment + best-effort step/domain recording hooks
common/src/test/java/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClientTest.java	Adds tests validating step emission and last-loaded-domain recording
changelog.txt	Documents the new onboarding telemetry hooks as a MINOR change

[Prvnkmr337]

Low priority — Consider using imports instead of fully-qualified class names

Throughout the new code, fully-qualified class names are used inline (e.g., com.microsoft.identity.common.java.telemetry.OnboardingTelemetryConstants.STEP_BROKER_INSTALL_PROMPTED), which makes the lines quite long and harder to scan.

Consider adding imports at the top of the file:

import com.microsoft.identity.common.internal.telemetry.OnboardingTelemetryRecorder;
import static com.microsoft.identity.common.java.telemetry.OnboardingTelemetryConstants.*;

This would shorten every call site from:

recordOnboardingStep(com.microsoft.identity.common.java.telemetry.OnboardingTelemetryConstants.STEP_BROKER_INSTALL_PROMPTED);

to:

recordOnboardingStep(STEP_BROKER_INSTALL_PROMPTED);

Non-blocking — purely a readability suggestion.

[Prvnkmr337]

Low priority — @Nullable on recordLastLoadedDomain parameter is misleading

The url parameter is annotated @Nullable, but the only caller is onPageFinished, where Android's WebViewClient.onPageFinished(WebView, String) declares url as @NonNull.

Since null is never an expected input, consider changing to @NonNull to better document the contract:

private void recordLastLoadedDomain(@NonNull final String url) {
    final ... recorder = mOnboardingTelemetryRecorder;
    if (recorder == null || url.isEmpty()) {
        return;
    }
    // ...
}

This avoids misleading readers into thinking null is a valid input and removes the unnecessary null check.

Non-blocking — purely a correctness-of-contract suggestion.

[Prvnkmr337]

Low priority — Add verbose log when host extraction yields null/empty

In recordLastLoadedDomain, when Uri.parse(url).getHost() returns null or empty for a non-empty URL, it silently falls through. This is an unexpected case that could indicate a malformed URL — a verbose log would help with diagnostics:

final String host = Uri.parse(url).getHost();
if (host != null && !host.isEmpty()) {
    recorder.setLastLoadedDomain(host);
} else {
    Logger.verbose(TAG, "Onboarding telemetry: no host extracted from URL");
}

Using Logger.verbose to keep it low-noise in production while still being available for debugging.

Non-blocking.

[Prvnkmr337]

Nit — Changelog entry missing PR number

The new changelog entry is missing the (#3121) suffix that all other entries follow:

-- [MINOR] Wire onboarding telemetry hooks into AzureActiveDirectoryWebViewClient for page-transition step capture (broker install, MDM enrollment, Company Portal launch, MFA linking) and last-loaded-domain tracking
++ [MINOR] Wire onboarding telemetry hooks into AzureActiveDirectoryWebViewClient for page-transition step capture (broker install, MDM enrollment, Company Portal launch, MFA linking) and last-loaded-domain tracking (#3121)

[wzhipan]

Rebased onto latest dev and resolved changelog conflicts. Please re-review when you get a chance.